Merge pull request #3278 from c-chaitanya/chromium-browser-renderer-fix

fix for chromium renderer on linux systems (issue #2348)

Author: nicolaskruchten

Diff for: packages/python/plotly/plotly/io/_base_renderers.py

@@ -669,6 +669,16 @@ def open_html_in_browser(html, using=None, new=0, autoraise=True):
     if isinstance(html, six.string_types):
         html = html.encode("utf8")
 
+    if isinstance(using, tuple):
+        try:
+            using = [i for i in webbrowser._browsers.keys() if i in using][0]
+        except IndexError:
+            raise ValueError(
+                """
+Unable to find the given browser.
+Try one among the following 'chrome', 'chromium', 'firefox' or 'default' """
+            )
+
     class OneShotRequestHandler(BaseHTTPRequestHandler):
         def do_GET(self):
             self.send_response(200)

Diff for: packages/python/plotly/plotly/io/_renderers.py

@@ -437,9 +437,11 @@ def show(fig, renderer=None, validate=True, **kwargs):
 
 # External
 renderers["browser"] = BrowserRenderer(config=config)
-renderers["firefox"] = BrowserRenderer(config=config, using="firefox")
-renderers["chrome"] = BrowserRenderer(config=config, using="chrome")
-renderers["chromium"] = BrowserRenderer(config=config, using="chromium")
+renderers["firefox"] = BrowserRenderer(config=config, using=("firefox"))
+renderers["chrome"] = BrowserRenderer(config=config, using=("chrome", "google-chrome"))
+renderers["chromium"] = BrowserRenderer(
+    config=config, using=("chromium", "chromium-browser")
+)
 renderers["iframe"] = IFrameRenderer(config=config, include_plotlyjs=True)
 renderers["iframe_connected"] = IFrameRenderer(config=config, include_plotlyjs="cdn")
 renderers["sphinx_gallery"] = SphinxGalleryHtmlRenderer()

Diff for: packages/python/plotly/plotly/tests/test_io/test_renderers.py

@@ -7,6 +7,7 @@
 import pytest
 import requests
 import numpy as np
+import webbrowser
 
 import plotly.graph_objs as go
 import plotly.io as pio
@@ -224,6 +225,8 @@ def test_notebook_connected_show(fig1, name, connected):
 def test_browser_renderer_show(fig1, renderer):
     pio.renderers.default = renderer
     renderer_obj = pio.renderers[renderer]
+    # scan through webbrowser._browsers.keys() and assign the browser name registered with os
+    renderer_obj.using = [i for i in webbrowser._browsers.keys() if renderer in i][0]
 
     # Setup mocks
     mock_get = MagicMock(name="test get")