Skip to content

Commit 80fe697

Browse files
fix tests
1 parent b57def2 commit 80fe697

File tree

1 file changed

+4
-5
lines changed
  • packages/python/plotly/plotly/express

1 file changed

+4
-5
lines changed

packages/python/plotly/plotly/express/_core.py

+4-5
Original file line numberDiff line numberDiff line change
@@ -1184,22 +1184,21 @@ def make_figure(args, constructor, trace_patch={}, layout_patch={}):
11841184
nrows = ncols = 1
11851185
col_labels = []
11861186
row_labels = []
1187-
trace_name_labels = []
1187+
trace_name_labels = None
11881188
for group_name in sorted_group_names:
11891189
group = grouped.get_group(group_name if len(group_name) > 1 else group_name[0])
11901190
mapping_labels = OrderedDict()
1191+
trace_name_labels = OrderedDict()
11911192
frame_name = ""
1192-
trace_name = []
11931193
for col, val, m in zip(grouper, group_name, grouped_mappings):
11941194
if col != one_group:
11951195
key = get_label(args, col)
11961196
mapping_labels[key] = str(val)
11971197
if m.show_in_trace_name:
1198-
trace_name_labels.append(key)
1199-
trace_name.append(str(val))
1198+
trace_name_labels[key] = str(val)
12001199
if m.variable == "animation_frame":
12011200
frame_name = val
1202-
trace_name = ", ".join(trace_name)
1201+
trace_name = ", ".join(trace_name_labels.values())
12031202
if frame_name not in trace_names_by_frame:
12041203
trace_names_by_frame[frame_name] = set()
12051204
trace_names = trace_names_by_frame[frame_name]

0 commit comments

Comments
 (0)