positive values only for logs

Author: nicolaskruchten

Diff for: packages/python/plotly/plotly/express/trendline_functions/__init__.py

@@ -45,16 +45,16 @@ def ols(trendline_options, x_raw, x, y, x_label, y_label, non_missing):
     log_y = trendline_options.get("log_y", False)
 
     if log_y:
-        if np.any(y == 0):
+        if np.any(y <= 0):
             raise ValueError(
-                "Can't do OLS trendline with `log_y=True` when `y` contains zeros."
+                "Can't do OLS trendline with `log_y=True` when `y` contains non-positive values."
             )
         y = np.log10(y)
         y_label = "log10(%s)" % y_label
     if log_x:
-        if np.any(x == 0):
+        if np.any(x <= 0):
             raise ValueError(
-                "Can't do OLS trendline with `log_x=True` when `x` contains zeros."
+                "Can't do OLS trendline with `log_x=True` when `x`  contains non-positive values."
             )
         x = np.log10(x)
         x_label = "log10(%s)" % x_label