Add support for strict option to in string validator

This allows numbers to be specified for non-strict string properties

Author: Jon M. Mease

_plotly_utils/basevalidators.py

@@ -667,7 +667,7 @@ def __init__(self,
         super().__init__(
             plotly_name=plotly_name, parent_name=parent_name, **kwargs)
         self.no_blank = no_blank
-        self.strict = strict  # Not implemented. We're always strict
+        self.strict = strict
         self.array_ok = array_ok
         self.values = values
 
@@ -694,6 +694,10 @@ def description(self):
             desc = desc + """
       - A string"""
 
+        if not self.strict:
+            desc = desc + """
+      - A number that will be converted to a string"""
+
         if self.array_ok:
             desc = desc + """
       - A tuple, list, or one-dimensional numpy array of the above"""
@@ -706,12 +710,13 @@ def validate_coerce(self, v):
             pass
         elif self.array_ok and is_array(v):
 
-            # Make sure all elements are strings. Is there a more efficient
-            # way to do this in numpy?
-            invalid_els = [e for e in v if not isinstance(e, str)]
-            if invalid_els:
-                self.raise_invalid_elements(invalid_els)
+            # If strict, make sure all elements are strings.
+            if self.strict:
+                invalid_els = [e for e in v if not isinstance(e, str)]
+                if invalid_els:
+                    self.raise_invalid_elements(invalid_els)
 
+            # If not strict, let numpy cast elements to strings
             v = copy_to_readonly_numpy_array(v, dtype='unicode')
 
             if self.no_blank:
@@ -725,8 +730,15 @@ def validate_coerce(self, v):
                 if invalid_els:
                     self.raise_invalid_elements(invalid_els)
         else:
-            if not isinstance(v, str):
-                self.raise_invalid_val(v)
+            if self.strict:
+                if not isinstance(v, str):
+                    self.raise_invalid_val(v)
+            else:
+                if not isinstance(v, (str, int, float)):
+                    self.raise_invalid_val(v)
+
+                # Convert value to a string
+                v = str(v)
 
             if self.no_blank and len(v) == 0:
                 self.raise_invalid_val(v)

_plotly_utils/tests/validators/test_string_validator.py

@@ -20,9 +20,14 @@ def validator_no_blanks():
     return StringValidator('prop', 'parent', no_blank=True)
 
 
+@pytest.fixture()
+def validator_strict():
+    return StringValidator('prop', 'parent', strict=True)
+
+
 @pytest.fixture
 def validator_aok():
-    return StringValidator('prop', 'parent', array_ok=True)
+    return StringValidator('prop', 'parent', array_ok=True, strict=True)
 
 
 @pytest.fixture
@@ -37,16 +42,18 @@ def validator_no_blanks_aok():
 
 # Array not ok
 # ------------
+# Not strict
 # ### Acceptance ###
 @pytest.mark.parametrize('val',
-                         ['bar', 'HELLO!!!', 'world!@#$%^&*()', ''])
+                         ['bar', 234, np.nan,
+                          'HELLO!!!', 'world!@#$%^&*()', ''])
 def test_acceptance(val, validator: StringValidator):
-    assert validator.validate_coerce(val) == val
+    assert validator.validate_coerce(val) == str(val)
 
 
 # ### Rejection by value ###
 @pytest.mark.parametrize('val',
-                         [(), [], [1, 2, 3], set(), np.nan, np.pi])
+                         [(), [], [1, 2, 3], set()])
 def test_rejection(val, validator: StringValidator):
     with pytest.raises(ValueError) as validation_failure:
         validator.validate_coerce(val)
@@ -88,6 +95,25 @@ def test_rejection_no_blanks(val, validator_no_blanks: StringValidator):
     assert 'A non-empty string' in str(validation_failure.value)
 
 
+# Strict
+# ------
+# ### Acceptance ###
+@pytest.mark.parametrize('val',
+                         ['bar', 'HELLO!!!', 'world!@#$%^&*()', ''])
+def test_acceptance_strict(val, validator_strict: StringValidator):
+    assert validator_strict.validate_coerce(val) == val
+
+
+# ### Rejection by value ###
+@pytest.mark.parametrize('val',
+                         [(), [], [1, 2, 3], set(), np.nan, np.pi, 23])
+def test_rejection_strict(val, validator_strict: StringValidator):
+    with pytest.raises(ValueError) as validation_failure:
+        validator_strict.validate_coerce(val)
+
+    assert 'Invalid value' in str(validation_failure.value)
+
+
 # Array ok
 # --------
 # ### Acceptance ###