Skip to content

Deprecate a bunch of figure factories #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolaskruchten opened this issue Nov 22, 2019 · 3 comments
Closed

Deprecate a bunch of figure factories #1922

nicolaskruchten opened this issue Nov 22, 2019 · 3 comments
Assignees
Milestone

Comments

@nicolaskruchten
Copy link
Contributor

nicolaskruchten commented Nov 22, 2019

These figure factories should probably be marked "deprecated" in the docstrings:

These have dedicated trace types now:

create_bullet(data[, markers, measures, …])
create_ohlc(open, high, low, close[, dates, …])
create_scatterplotmatrix(df[, index, …])
create_table(table_text[, colorscale, …])
create_violin(data[, data_header, …])
create_candlestick(open, high, low, close[, …])

These are basically best done using PX if possible:

create_2d_density(x, y[, colorscale, …])
create_distplot(hist_data, group_labels[, …])
create_facet_grid(df[, x, y, facet_row, …])
@emmanuelle
Copy link
Contributor

Should I just modifiy the docstrings or should we completely deprecate the functions?

@nicolaskruchten
Copy link
Contributor Author

Let's start by just modifying the docstrings... Right now some of them say "BETA" which is kind of the wrong impression IMO :P

@emmanuelle
Copy link
Contributor

Addressed in #1921.

@nicolaskruchten nicolaskruchten added this to the v4.3.1 milestone Nov 28, 2019
@jonmmease jonmmease modified the milestones: v4.3.1, v4.4.0 Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants