-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
enable non-cartesian facets in Plotly Express: polar, ternary, maps etc #2646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd like to work on this if it's still not on any internal roadmap? I see you pointed to this bit of code. Presumably the px API would also need expanding to accept the |
Hi @inkychris ! No one is working on this at the moment so if you want to take it on, I'd love to accept a PR :) I actually activated this for In principle, it's as easy as just adding the |
Okay cool. I haven't explored the code base yet but is this/does this need to be covered by unit tests or should it just be a case of tuning things until it looks okay and getting you/someone to verify it? |
Hehe, well, I'm not proud to notice that my PR didn't have any tests, so clearly at the time I didn't feel that worried about it. Let's get things looking OK and then I'll see if anything warrants some tests. If so, they'll probably need to be fairly generic ones that I can write ;) |
Do you agree that polar plots should end up with the same scaling by default? If not then that makes things a bit simpler! |
I'm not sure I understand the question... what does "same scaling" mean in this case? |
Polar graphs scale to fit the data so the axes aren't the same for each facet by default like they are with scatter plots. |
Oh I see. This one is a bit tricky... for cartesian we added special Plotly.js handling to "match" axes, and in principle someday we'll do the same for polar, ternary and all the others, so I don't think that PX should do this. This will make the experience of making faceted polar charts less nice, because users will have to explicitly force the ranges to match via |
Hey, Any update on the facets in PX maps? Kind regards |
Today PX only supports faceting for 2d-cartesian functions, but it should support faceting for all functions, in principle.
The text was updated successfully, but these errors were encountered: