Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "react-diff-viewer" dependency with "react-diff-viewer-continued" #75

Closed
tadwohlrapp opened this issue Nov 8, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@tadwohlrapp
Copy link

Bug report

Describe the bug

I get the following warnings when installing strapi-plugin-config-sync:

warning "strapi-plugin-config-sync > [email protected]" has incorrect peer dependency "react@^15.3.0 || ^16.0.0".
warning "strapi-plugin-config-sync > [email protected]" has incorrect peer dependency "react-dom@^15.3.0 || ^16.0.0".

react-diff-viewer seems to be abandoned (last update was in May 2020) and there is a successor fork called react-diff-viewer-continued (npm package).

Steps to reproduce the behavior

  1. Use yarn
  2. Have a React version higher than v16.x installed (or no React installed, which would cause a has unmet peer dependency warning)
  3. Run yarn add strapi-plugin-config-sync
  4. See error

Expected behavior

Use currently maintained dependencies which don't cause warnings

Screenshots

image

System

  • Node.js version: 16.18.0 LTS
  • NPM version: 8.19.2
  • Strapi version: 4.4.7
  • Plugin version: 1.0.4
  • Database: SQLite
  • Operating system: macOS
@boazpoolman
Copy link
Member

Excellent suggestion. It makes sense to switch to the new package.

@boazpoolman boazpoolman added the enhancement New feature or request label Nov 9, 2022
@boazpoolman
Copy link
Member

Made the change directly on the master branch. See commit.
I'll release it with the next release of the plugin :)

@boazpoolman
Copy link
Member

This was released with v1.1.0 of the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants