update module imports; use formatted string literals; remove uneeded code

Author: pmacMaps

print_errors.py

@@ -8,7 +8,7 @@
 #
 # Created:     08/22/2019
 #
-# Updated:     1/31/2022
+# Updated:     9/21/2022
 #-------------------------------------------------------------------------------
 
 import sys
@@ -23,7 +23,7 @@ def print_exception(error):
     linecache.checkcache(filename)
     line = linecache.getline(filename, lineno, f.f_globals)
     # add message
-    message = '\nError: {}\nFILE: {}, LINE: {}\n\n\t "{}": {}'.format(error, filename, lineno, line.strip(), exc_obj)
+    message = f'\nError: {error}\nFILE: {filename}, LINE: {lineno}\n\n\t "{line.strip()}": {exc_obj}'
     # return to variable
     return message
 # end PrintException

sde_to_file_geodatabase_replica.py

@@ -5,7 +5,7 @@
 #
 # Created on: 05/12/2016
 #
-# Updated on: 4/26/2022
+# Updated on: 9/21/2022
 #
 # Description: Synchronizes updates between a parent and child replica geodatabase in favor of the parent.
 # The parent geodatabase is a SDE enterprise geodatabase. The child is a file geodatabase
@@ -15,20 +15,21 @@
 # Import system modules
 import arcpy
 import sys
-import datetime
 import time
+from datetime import date
+from os import path
 
 # attempt to run code. if an error occurs, break to except statement
 try:
     # capture the date the script is being run
-    date_today = datetime.date.today()
+    date_today = date.today()
     # convert date format to month-day-year (1-1-2020)
     formatted_date_today = date_today.strftime("%m-%d-%Y")
     # placeholder for messages for text file
     log_message = ''
     # text file to write messages to
     # TODO: update path
-    log_file = r'C:\GIS\Results\Database_Maint_Report_{}.txt'.format(date_today)
+    log_file = path.join( r'C:\GIS\Results', f'Database_Maint_Report_{formatted_date_today}.txt' )
 
     # SDE is parent geodatabase in replication
     # TODO: update path for sde connection
@@ -40,25 +41,18 @@
     # Process: Synchronize Changes
     # Replicates data from parent to child geodatabase
     # TODO: update the name of the replication
-    result = arcpy.SynchronizeChanges_management(sde, "Name of Replication", child_gdb, "FROM_GEODATABASE1_TO_2", "IN_FAVOR_OF_GDB1", "BY_OBJECT", "DO_NOT_RECONCILE")
+    arcpy.SynchronizeChanges_management(sde, "Name of Replication", child_gdb, "FROM_GEODATABASE1_TO_2", "IN_FAVOR_OF_GDB1", "BY_OBJECT", "DO_NOT_RECONCILE")
 
-    # delay writing results until geoprocessing tool gets the completed code
-    while result.status < 4:
-        time.sleep(0.2)
-    # store tool result message in a variable
-    resultValue = result.getMessages()
-    # add the tool's message to the log message
-    log_message += "completed {}\n".format(str(resultValue))
     # add a more human readable message to log message
-    log_message += "\nSuccessfully ran replication from {} to {} on {}\n".format(sde, child_gdb, formatted_date_today)
+    log_message += f"\nSuccessfully ran replication from {sde} to {child_gdb} on {formatted_date_today}\n"
 # If an error occurs running geoprocessing tool(s) capture error and write message
 # handle error outside of Python system
 except (EnvironmentError, Exception) as e:
     tbE = sys.exc_info()[2]
     # add the line number the error occured to the log message
-    log_message += "\nFailed at Line {}\n".format(tbE.tb_lineno)
+    log_message += f"\nFailed at Line {tbE.tb_lineno}\n"
     # add the error message to the log message
-    log_message += "\nError: {}\n".format(str(e))
+    log_message += f"\nError: {str(e)}\n"
 finally:
     # write message to log file
     try: