Skip to content

Commit 35c2f31

Browse files
committed
Apply PR suggestions
1 parent 56b2cd0 commit 35c2f31

File tree

3 files changed

+29
-34
lines changed

3 files changed

+29
-34
lines changed

.github/workflows/check_pr.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ jobs:
119119
node-version: 18
120120

121121
- name: Install dependencies
122-
run: npm install --frozen-lockfile
122+
run: npm ci
123123
working-directory: docs
124124

125-
- name: Test build docs
125+
- name: Build docs
126126
run: npm run build
127127
working-directory: docs

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,10 @@ jobs:
8787
node-version: 18
8888

8989
- name: Install dependencies
90-
run: npm install --frozen-lockfile
90+
run: npm ci
9191
working-directory: docs
9292

93-
- name: Test build docs
93+
- name: Build docs
9494
run: npm run build
9595
working-directory: docs
9696
publish:

.github/workflows/release_next.yml

Lines changed: 25 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
with:
111111
name: coverage-${{ matrix.os }}-${{ matrix.nodeRun }}
112112
path: coverage.tar
113-
test_docs:
113+
build_docs:
114114
if: github.repository_owner == 'pnp'
115115
runs-on: ubuntu-latest
116116

@@ -121,12 +121,34 @@ jobs:
121121
node-version: 18
122122

123123
- name: Install dependencies
124-
run: npm install --frozen-lockfile
124+
run: npm ci
125125
working-directory: docs
126126

127-
- name: Test build docs
127+
- name: Build docs
128128
run: npm run build
129129
working-directory: docs
130+
131+
- name: Upload artifact
132+
uses: actions/upload-pages-artifact@v1
133+
with:
134+
path: docs/build
135+
deploy_docs:
136+
if: github.repository_owner == 'pnp'
137+
needs: build_docs
138+
139+
permissions:
140+
pages: write
141+
id-token: write
142+
143+
environment:
144+
name: github-pages
145+
url: ${{ steps.deployment.outputs.page_url }}
146+
147+
runs-on: ubuntu-latest
148+
steps:
149+
- name: Deploy to GitHub Pages
150+
id: deployment
151+
uses: actions/deploy-pages@v2
130152
publish_next:
131153
if: github.repository_owner == 'pnp'
132154
needs: [test, test_docs]
@@ -169,33 +191,6 @@ jobs:
169191
with:
170192
name: build-ubuntu-latest-18
171193
path: build.tar
172-
deploy_docs:
173-
if: github.repository_owner == 'pnp'
174-
needs: publish_next
175-
runs-on: ubuntu-latest
176-
177-
steps:
178-
- uses: actions/checkout@v3
179-
- uses: actions/setup-node@v3
180-
with:
181-
node-version: 18
182-
183-
- name: Install dependencies
184-
run: npm install --frozen-lockfile
185-
working-directory: docs
186-
187-
- name: Test build docs
188-
run: npm run build
189-
working-directory: docs
190-
191-
- name: Deploy to GitHub Pages
192-
uses: peaceiris/actions-gh-pages@v3
193-
working-directory: docs
194-
with:
195-
github_token: ${{ secrets.GITHUB_TOKEN }}
196-
publish_dir: ./build
197-
user_name: github-actions[bot]
198-
user_email: 41898282+github-actions[bot]@users.noreply.github.com
199194
deploy_docker:
200195
if: github.repository_owner == 'pnp'
201196
needs: publish_next

0 commit comments

Comments
 (0)