Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only recompose selection, honoring startOffsets/endOffsets #5

Open
pocmo opened this issue Sep 15, 2020 · 0 comments
Open

Only recompose selection, honoring startOffsets/endOffsets #5

pocmo opened this issue Sep 15, 2020 · 0 comments
Labels
bug Something isn't working plugin Issues about the IntelliJ IDEA / Android Studio plugin.
Milestone
Shipping plugin

Comments

@pocmo
Copy link
Owner

pocmo commented Sep 15, 2020

Currently when copying layout XML with the plugin and pasting it into code, we will translate the whole file and paste the whole translation. That's of course not right and we need to look at the actual selection using startOffsets and endOffsets.

Of course using the selection means we may get incomplete XML or multiple "root" nodes. I am not sure what XMLPullParser will do with that. We may need to "fix up" the XML before processing it. Or manually reduce the selection to a valid XML subset.
@pocmo pocmo added bug Something isn't working plugin Issues about the IntelliJ IDEA / Android Studio plugin. labels Sep 15, 2020
@pocmo pocmo mentioned this issue Sep 20, 2020
Open
@pocmo pocmo mentioned this issue Sep 30, 2020
Merged
@pocmo pocmo added this to the Shipping plugin milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working plugin Issues about the IntelliJ IDEA / Android Studio plugin.
Projects
None yet
Milestone
Shipping plugin
Development

No branches or pull requests
1 participant
@pocmo