Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Supplier] Delay newly staked Supplier activation until next session #695

Closed
5 tasks
red-0ne opened this issue Jul 16, 2024 · 1 comment
Closed
5 tasks
Assignees
Labels
on-chain On-chain business logic supplier Changes related to the Supplier actor

Comments

@red-0ne
Copy link
Contributor

red-0ne commented Jul 16, 2024

Objective

Prevent newly staked Suppliers from being included in an already started Session and delay their "activation" until the next one starts.

Origin Document

If a Supplier stakes mid-session, there is a possibility of having it included in a Session. This might force Gateways and Applications to updates their Sessions Supplier list at each block.

image

Goals

  • Prevent including Suppliers in a Session if this one has already started.
  • Save the Gateways and Applications the need to update the active Session's Suppliers at each block.

Deliverables

  • A single PR that:
    • Adds a field in the Supplier proto to indicate when it is allowed to be included in Sessions.
    • Use the above info to filter-out Suppliers that are not active yet.

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @red-0ne

@red-0ne red-0ne added supplier Changes related to the Supplier actor on-chain On-chain business logic labels Jul 16, 2024
@red-0ne red-0ne self-assigned this Jul 16, 2024
@red-0ne red-0ne added this to Shannon Jul 16, 2024
@red-0ne red-0ne moved this to 🔖 Ready in Shannon Jul 16, 2024
@bryanchriswhite bryanchriswhite changed the title [Supllier] Delay newly staked Supplier activation until next session [Suplier] Delay newly staked Supplier activation until next session Jul 18, 2024
@bryanchriswhite bryanchriswhite changed the title [Suplier] Delay newly staked Supplier activation until next session [Supplier] Delay newly staked Supplier activation until next session Jul 18, 2024
@red-0ne red-0ne moved this from 🔖 Ready to 🏗 In progress in Shannon Jul 24, 2024
@red-0ne
Copy link
Contributor Author

red-0ne commented Aug 2, 2024

Completed as per #707

@red-0ne red-0ne closed this as completed Aug 2, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Shannon Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-chain On-chain business logic supplier Changes related to the Supplier actor
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant