-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix(python): Suggest str.contains for string containment in map_elements #25472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25472 +/- ##
==========================================
+ Coverage 79.58% 79.64% +0.06%
==========================================
Files 1743 1743
Lines 240439 240460 +21
Branches 3038 3044 +6
==========================================
+ Hits 191347 191517 +170
+ Misses 48310 48159 -151
- Partials 782 784 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e1a1e11 to
10c86d5
Compare
|
Nice; when you think it's ready to roll, ping me and I'll review ;) |
|
@alexander-beedie Ready for review. 🏓 |
ac2fbe6 to
1028d0d
Compare
Nice; will take a look at the weekend :) |
2f16598 to
2f54647
Compare
|
Umm... THIS weekend 😄 |
001d48f to
88fb829
Compare
Co-authored-by: Claude <[email protected]>
Fixes #17182.
PolarsInefficientMapWarningincorrectly suggested.is_in()for string containment operations likesubstring in stringinsidemap_elements.Cause
Bytecode parser treated all
inoperations identically without checking operand types.Fix
Use runtime type checking via
_get_all_caller_variables()to distinguish:.is_in().str.contains()with properpl.lit()wrapping