Skip to content

Conversation

@itamarst
Copy link
Contributor

Another followup bug fix to the already merged #25412.

This time, ensuring that string literals actually generate column predicates. Lacking this PR, regexs do work, but nothing is generated for literals due to a bad assumption about strictness, so you don't get predicate pushdown.

Per Gijs this code is apparently used in streaming Parquet reading?

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 25, 2025
@itamarst itamarst marked this pull request as ready for review November 25, 2025 23:22
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.17%. Comparing base (9250243) to head (1299cbe).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ars-plan/src/plans/aexpr/predicates/column_expr.rs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25495   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files        1727     1727           
  Lines      240245   240262   +17     
  Branches     3033     3033           
=======================================
+ Hits       197410   197426   +16     
- Misses      42054    42055    +1     
  Partials      781      781           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ritchie46
Copy link
Member

Do we miss an optimization opportunity, or do we actually read in rows we shouldn't? If the latter, can you come up with an MWE?

@itamarst
Copy link
Contributor Author

itamarst commented Nov 26, 2025

I initially categorized it as a fix because the preexisting code was buggy and didn't work as intended. But... from a user perspective it's more of a missed optimization. So for changelog purposes I guess it's perf. I'll change the title for this and the other PR.

@itamarst itamarst changed the title fix: Ensure string literals actually generate ColumnPredicates perf: Ensure string literals actually generate ColumnPredicates Nov 26, 2025
@github-actions github-actions bot added the performance Performance issues or improvements label Nov 26, 2025
@itamarst
Copy link
Contributor Author

itamarst commented Dec 1, 2025

I merged forward and fixed conflicts, so this should be ready for review again. The coverage failure is due to running out of disk space(!) and I can't rerun it with my permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants