Skip to content

Conversation

@edizeqiri
Copy link

This PR closes #24807.

Changes

  • Added a check at the end of the reshape to ensure the height is valid for the given reshape size.

Testing

  • Added a test reflecting the issue and changed one test which did a invalid reshape.

@edizeqiri edizeqiri changed the title fix: reshape checks size to match exactly fix(rust): Reshape checks size to match exactly Dec 1, 2025
@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars and removed title needs formatting labels Dec 1, 2025
@edizeqiri
Copy link
Author

The lint error doesn’t appear to be related to my changes

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.42%. Comparing base (9a5b318) to head (7761c86).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25571      +/-   ##
==========================================
- Coverage   79.45%   79.42%   -0.03%     
==========================================
  Files        1743     1743              
  Lines      240311   240316       +5     
  Branches     3038     3038              
==========================================
- Hits       190932   190880      -52     
- Misses      48596    48653      +57     
  Partials      783      783              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edizeqiri edizeqiri force-pushed the reshape-correct-size branch from 1c46ce0 to 7dd5ff5 Compare December 2, 2025 11:28
@edizeqiri edizeqiri force-pushed the reshape-correct-size branch from 7dd5ff5 to 0eaa5d5 Compare December 2, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reshaping into invalid shapes has inconsistent error behavior

1 participant