-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: Make struct.with_fields data model coherent
#25610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kdn36
wants to merge
18
commits into
pola-rs:main
Choose a base branch
from
kdn36:refactor_struct_with_fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,344
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #25610 +/- ##
==========================================
+ Coverage 79.58% 79.69% +0.11%
==========================================
Files 1743 1745 +2
Lines 240439 240720 +281
Branches 3038 3038
==========================================
+ Hits 191347 191838 +491
+ Misses 48310 48100 -210
Partials 782 782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eeaaf41 to
fd46ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-dtype-struct
Area: struct data type
fix
Bug fix
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24687
fixes #24568
fixes #18461
This PR introduces changes in the DSL, IR and Physical engines (both in-memory and streaming) for
struct.with_fields(), such that its data model is coherent.Pending performance regression analysis.