Skip to content

perf: Correct overly eager local predicate insertion for unpivot #25644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Voultapher wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: Correct overly eager local predicate insertion for unpivot #25644

Voultapher wants to merge 1 commit into from
+45 −3

Conversation

@Voultapher
Copy link
Collaborator

@Voultapher Voultapher commented Dec 5, 2025

No description provided.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 5, 2025
@Voultapher Voultapher changed the title fix: Fix overly eager local predicate insertion for unpivot fix: overly eager local predicate insertion for unpivot Dec 5, 2025
@Voultapher Voultapher changed the title fix: overly eager local predicate insertion for unpivot fix: Correct overly eager local predicate insertion for unpivot Dec 5, 2025
@Voultapher Voultapher changed the title fix: Correct overly eager local predicate insertion for unpivot perf: Correct overly eager local predicate insertion for unpivot Dec 5, 2025
@github-actions github-actions bot added the performance Performance issues or improvements label Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.66%. Comparing base (cba9324) to head (1a52e86).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #25644      +/-   ##
==========================================
+ Coverage   79.49%   79.66%   +0.16%     
==========================================
  Files        1742     1743       +1     
  Lines      240147   240455     +308     
  Branches     3038     3038              
==========================================
+ Hits       190909   191560     +651     
+ Misses      48455    48113     -342     
+ Partials      783      782       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

fix Bug fix performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Voultapher