Skip to content

Conversation

@Voultapher
Copy link
Collaborator

  • Consistently use Use get_literal_name in implementation
  • Consistently use const
  • Use PlSmallString::from_static effectively

- Consistently use Use get_literal_name in implementation
- Consistently use const
- Use PlSmallString::from_static effectively
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Dec 5, 2025
@Voultapher
Copy link
Collaborator Author

Literally every single place calling the get_.*_name() functions was cloning the result so I made the functions return an owned PlSmallString to reduce visual noise in the callers.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.68%. Comparing base (ae8a737) to head (4192ba2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/lit.rs 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25645      +/-   ##
==========================================
+ Coverage   79.66%   79.68%   +0.02%     
==========================================
  Files        1743     1743              
  Lines      240457   240450       -7     
  Branches     3038     3038              
==========================================
+ Hits       191560   191604      +44     
+ Misses      48115    48063      -52     
- Partials      782      783       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant