fix: Verify arr namespace is called from array column
#25650
+109
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
mcrumiller
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
orlp,
reswqa and
ritchie46
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25650 +/- ##
==========================================
- Coverage 79.58% 79.49% -0.09%
==========================================
Files 1743 1743
Lines 240439 240455 +16
Branches 3038 3038
==========================================
- Hits 191347 191150 -197
- Misses 48310 48523 +213
Partials 782 782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcrumiller
commented
Dec 6, 2025
Comment on lines
+63
to
+74
| impl<'a> FieldsMapper<'a> { | ||
| /// Validate that the dtype is a List. | ||
| pub fn ensure_is_list(self) -> PolarsResult<Self> { | ||
| let dt = self.args()[0].dtype(); | ||
| polars_ensure!( | ||
| dt.is_list(), | ||
| InvalidOperation: format!("expected List data type for list operation, got: {:?}", dt) | ||
| ); | ||
| Ok(self) | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I moved this here since it's only ever referenced in this module, so it makes a bit more sense here. Also, we now use the debug formatting for the output datatype to better align with our polars datatypes, i.e. we now get List(Int8) instead of list[i8].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25648.
I left out
arr.aggandarr.evalfrom the unit test because these take a separate path and have a separate error message.