Skip to content

mutation webhook fail to inject sidecar when installed by helm #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jayl1e opened this issue May 7, 2025 · 0 comments · May be fixed by #207
Open

mutation webhook fail to inject sidecar when installed by helm #206

jayl1e opened this issue May 7, 2025 · 0 comments · May be fixed by #207
Labels
bug Something isn't working

Comments

@jayl1e
Copy link

jayl1e commented May 7, 2025 •
edited
Loading

Describe the bug
I install controller with helm charts, the mutation webhook failed to modify pod, it report error:

{"kind":"AdmissionReview","apiVersion":"admission.k8s.io/v1","response":{"allowed":false,"status":{"metadata":{},"message":"failed parsing injected YAML (check sidecar injector configuration): error converting YAML to JSON: yaml: line 57: did not find expected key"}}}

To Reproduce
just helm install

Expected behavior
mutate pod successfully

Environment

  • Version: k8s 1.32
  • OS: debian 12

Additional context
the template is wrong
helm verison template is bad, however k8s yaml version is correnct

polaris-controller/deploy/kubernetes_v1.22/helm/templates/_params.tpl

Line 55 in 42d43fd

value: "{{ "{{" }} index .ObjectMeta.Annotations `sidecar.polarismesh.cn/envoyMetadata` {{ "}}" }}"

polaris-controller/deploy/kubernetes_v1.22/kubernetes/injector.yaml

Line 221 in 42d43fd

value: {{index .ObjectMeta.Annotations `sidecar.polarismesh.cn/envoyMetadata`}}

@jayl1e jayl1e added the bug Something isn't working label May 7, 2025
@jayl1e jayl1e linked a pull request May 7, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: mutation webhook jayl1e/polaris-controller
1 participant
@jayl1e