-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PolkaJS unable to decode valid block #10432
Comments
Hi, this issue still occurs regularly for us, so I've spent some more time investigating it. I believe it boils down to the following discrepancy: I think that somewhere in this function https://github.com/polkadot-js/api/blob/a15d0dd0df6b0ba87d88eb7f637b9e1d6e0fb87a/packages/rpc-core/src/bundle.ts#L499 |
Thanks for doing the initial research, I am looking into this as we speak! |
@TarikGul here is some (possibly) relevant context - there was a similar issue with scale-typegen: |
For your information, it is possible to hack this to work, by not relying on the outputTypeName to be unique and instead constructing the lookup name. in polkadot/rpc-core/bundle.js you could modify "_newType" like this
Essentially i lookup the typeid of the output value of the method in the registry and then use that instead of the name. It works for me, but obviously you could make this more elegant. |
Current behaviour: polkaJS is unable to decode this Chainflip block:
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fmainnet-archive.chainflip.io#/explorer/query/0xf7d516bd72ee1d76903e692157fc2a5260788faa6c9b6a369c3006b19413b6d2
Blocks before and after decode fine (2053085 is the block height of the failing block).
The Chainflip block explorer can decode the block:
https://scan.chainflip.io/blocks/2053085
The issue appears to be a type
ChainAsset<T, I>
which is an alias for a chain-specific enum of assets. (See 'asset' in Governance.propose_governance_extrinsic extrinsic in the Chainflip block explorer).For example, there is an Ethereum instance of ChainAsset that resolves to an eth::Asset:
enum Asset { Eth, Flip, Usdc, Usdt }
. Another instance resolves to a btc::Asset:enum Asset { Btc }
.The problem seems to be that polkaJS is trying to resolve an encoded eth::Asset::Usdt to a btc::Asset. Since btc::Asset only has one variant, the decoding fails.
I'm not sure if the source of the issue is indeed polkaJS, or scale metadata, or a combination of the two.
I'm also not sure if this can be mitigated or avoided by declaring our substrate types a bit differently.
Any advice would be welcome.
The encoding is correct, and is compatible with substrate / metadata. We use similar patterns elsewhere - this seems like something that polkaJs should be able to handle.
Some tools seem to be able to correctly decode this type using the metadata. For example, subxt codegen correctly disambiguates the types.
Version:
Environment:
Language:
The text was updated successfully, but these errors were encountered: