Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Cosmic-edit doesn't close after pressing "close without saving" #302

Closed
feikedonia opened this issue Jan 18, 2025 · 8 comments
Closed

Comments

@feikedonia
Copy link
Contributor

feikedonia commented Jan 18, 2025

I cannot press the close without saving button,
as well as cannot Cancel nor Save as...

With this window open, I can't even press on the window close button...
Close button
Image

I am in a stacked window, maybe that's important?
→ Edit, 2025-02-14: being in a stacked window ís important, otherwise Cosmic-edit cóúld be closed, but when stacked, it couldn't.

cosmic-session-git 1.0.0.alpha.5.1.r0.g6e48e12-1

"Wijzigingen niet opslaan" → Don't save Changes
"Annuleren" → cancel, "Wijzigingen verwerpen" → Don't save...
Image

@feikedonia
Copy link
Contributor Author

I could only close the program with a system monitor (terminate process...)

@feikedonia feikedonia changed the title [bug] can't close without saving [bug] can't close window when stacked Feb 14, 2025
@iamkartiknayak
Copy link
Contributor

I think it has been fixed, can you please check and verify?

@feikedonia
Copy link
Contributor Author

feikedonia commented Mar 10, 2025

No, it is still there:

steps to reproduce

  1. open Cosmic-Edit
  2. type something
  3. close the tab, not the window
  4. press "save without closing"
  5. Cosmic-Edit stays open, but without your typed input.

step 3; close the tab, not the window
Image

@feikedonia feikedonia changed the title [bug] can't close window when stacked [bug] Cosmic-edit doesn't close after pressing "close without saving" Mar 10, 2025
@iamkartiknayak
Copy link
Contributor

iamkartiknayak commented Mar 10, 2025

It's working fine for me though
Are you on popdev-master?

cosmic-edit:
  Installed: 0.1.0~1741529916~24.04~bd5009a

2025-03-10.18-12-54.mp4

@feikedonia
Copy link
Contributor Author

feikedonia commented Mar 10, 2025

See the edited thingy

Image

@iamkartiknayak
Copy link
Contributor

iamkartiknayak commented Mar 10, 2025

We asked it to close the tab then we proceed to save it before closing (same as close window). So it saves the file and resets the tab data
If you use save option directly it doesn't reset the data.

I think the way it's currently working makes sense?

@feikedonia
Copy link
Contributor Author

You are right, I think... wait:

we can compare, can't we

I open Kate...

writing something
Image

closing without saving
Image

it closes the current document and goes back to the "home" screen
Image

Should there be always a document open then? Because then it's fine, I think. Cosmic-Edit doesn't need to behave exactly like Kate does.

@iamkartiknayak
Copy link
Contributor

It could be the design choice of COSMIC Edit to keep at least one tab open at all time since they don't have a home screen setup. If there are no tabs open users have to eventually open a new tab to work with editor so current impl is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants