Skip to content

Commit 805683f

Browse files
committed
feat: sound page dropdown popups
1 parent 0ae6f0b commit 805683f

File tree

3 files changed

+56
-71
lines changed

3 files changed

+56
-71
lines changed

Cargo.lock

+11-19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cosmic-settings/src/app.rs

+12-28
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,10 @@ use crate::pages::{self, display, system, time};
1919
use crate::subscription::desktop_files;
2020
use crate::widget::{page_title, search_header};
2121
use crate::PageCommands;
22-
use cosmic::app::command::set_theme;
2322
use cosmic::app::context_drawer::ContextDrawer;
24-
#[cfg(feature = "single-instance")]
25-
use cosmic::app::DbusActivationMessage;
2623
#[cfg(feature = "wayland")]
2724
use cosmic::cctk::{sctk::output::OutputInfo, wayland_client::protocol::wl_output::WlOutput};
2825
use cosmic::iced::Subscription;
29-
use cosmic::surface_message::SurfaceMessage;
3026
use cosmic::widget::{self, button, row, text_input};
3127
use cosmic::{
3228
app::{Core, Task},
@@ -36,6 +32,7 @@ use cosmic::{
3632
window, Length,
3733
},
3834
prelude::*,
35+
surface,
3936
widget::{
4037
column, container, icon, id_container, nav_bar, scrollable, segmented_button, settings,
4138
},
@@ -140,23 +137,6 @@ impl SettingsApp {
140137
}
141138
}
142139

143-
#[cfg(feature = "wayland")]
144-
impl From<Message> for cosmic::surface_message::MessageWrapper<Message> {
145-
fn from(value: Message) -> Self {
146-
match value {
147-
Message::Surface(msg) => cosmic::surface_message::MessageWrapper::Surface(msg),
148-
msg => cosmic::surface_message::MessageWrapper::Message(msg),
149-
}
150-
}
151-
}
152-
153-
#[cfg(feature = "wayland")]
154-
impl From<SurfaceMessage> for Message {
155-
fn from(value: SurfaceMessage) -> Self {
156-
Message::Surface(value)
157-
}
158-
}
159-
160140
#[derive(Clone, Debug)]
161141
pub enum Message {
162142
CloseContextDrawer,
@@ -179,7 +159,7 @@ pub enum Message {
179159
SearchSubmit,
180160
SetTheme(cosmic::theme::Theme),
181161
SetWindowTitle,
182-
Surface(SurfaceMessage),
162+
Surface(surface::Action),
183163
}
184164

185165
impl cosmic::Application for SettingsApp {
@@ -737,7 +717,7 @@ impl cosmic::Application for SettingsApp {
737717
}
738718
}
739719

740-
Message::SetTheme(t) => return set_theme(t),
720+
Message::SetTheme(t) => return cosmic::command::set_theme(t),
741721

742722
Message::OpenContextDrawer(page, title) => {
743723
self.core.window.show_context = true;
@@ -753,18 +733,22 @@ impl cosmic::Application for SettingsApp {
753733
Message::Error(error) => {
754734
tracing::error!(error, "error occurred");
755735
}
756-
Message::Surface(_) => {}
736+
Message::Surface(a) => {
737+
return cosmic::task::message(cosmic::Action::Cosmic(
738+
cosmic::app::Action::Surface(a),
739+
));
740+
}
757741
}
758742

759743
Task::none()
760744
}
761745

762746
#[cfg(feature = "single-instance")]
763-
fn dbus_activation(&mut self, msg: DbusActivationMessage) -> Task<Self::Message> {
747+
fn dbus_activation(&mut self, msg: cosmic::dbus_activation::Message) -> Task<Self::Message> {
764748
match msg.msg {
765-
cosmic::app::DbusActivationDetails::Activate
766-
| cosmic::app::DbusActivationDetails::Open { .. } => None,
767-
cosmic::app::DbusActivationDetails::ActivateAction { action, .. } => {
749+
cosmic::dbus_activation::Details::Activate
750+
| cosmic::dbus_activation::Details::Open { .. } => None,
751+
cosmic::dbus_activation::Details::ActivateAction { action, .. } => {
768752
PageCommands::from_str(&action)
769753
.ok()
770754
.and_then(|action| self.subtask_to_page(&action))

0 commit comments

Comments
 (0)