Skip to content

Conversation

@jordandelbar
Copy link

@jordandelbar jordandelbar commented Jun 11, 2025

I recently encountered the ligature issue in Zed and found #378.
This PR adds a check to ensure that ligature patterns are not broken.

disclaimer: font rendering and font shaping are not within my domain of competence and I shamelessly vibe coded it + verify that the tests + clippy & examples pass but I am not in capacity to ensure that it does not have other impacts (performance wise, etc) or if this is the correct way to fix this.

Closes #378

In zed

before:
Screenshot From 2025-06-11 16-29-50

after (built with my branch as source for cosmic-text):
Screenshot From 2025-06-11 16-42-52

@jackpot51
Copy link
Member

This may be okay, but I need to do testing, and there could be a way to fix this without hardcoding ligatures.

@peppidesu
Copy link

I don't know if there is a way to retrieve a list of ligatures of a font. This would still leave another issue though: ligatures should be broken when necessary, which this solution prevents from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some ligatures are not being applied

3 participants