Add check for ligature patterns #392
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently encountered the ligature issue in Zed and found #378.
This PR adds a check to ensure that ligature patterns are not broken.
disclaimer: font rendering and font shaping are not within my domain of competence and I shamelessly vibe coded it + verify that the tests + clippy & examples pass but I am not in capacity to ensure that it does not have other impacts (performance wise, etc) or if this is the correct way to fix this.
Closes #378
In zed
before:

after (built with my branch as source for cosmic-text):
