If an Exception is thrown during a @before hook, in the report, the scenario is displayed as "passed" #34

* fixes calculation of duration and failedStepCounts in features-overview
* mark scenarios as failed when exceptions in @before hook is thrown

Author: klausbayrhammer

cucumber-formatter/src/test/java/at/porscheinformatik/cucumber/formatter/RpnCalculatorStepdefs.java

@@ -56,6 +56,11 @@ public void before()
         System.out.println("Runs before scenarios *not* tagged with @foo");
     }
 
+    @Before("@ExceptionOnBefore")
+    public void beforeWithException() {
+        throw new RuntimeException("Exception in @Before");
+    }
+
     @After
     public void after(Scenario scenario)
     {

cucumber-formatter/src/test/resources/at/porscheinformatik/cucumber/formatter/exception_in_before.feature

@@ -0,0 +1,7 @@
+@ExceptionOnBefore
+Feature: Check whether an exception in the before-hook doesn't mess up the report
+
+  Scenario: Simple Addition
+    Given a calculator I just turned on
+    When I add 4 and 5
+    Then the result is 9

cucumber-report-web/src/main/resources/static/js/app.js

@@ -26,7 +26,7 @@
 			function getFailedScenarioCount(feature) {
 				var failedScenarios = 0;
 				feature.scenarios.forEach(function(scenario) {
-					if(scenario.result.failedStepCount){
+					if(scenario.result.failedStepCount || scenario.result.stepCount === scenario.result.skippedStepCount){
 						failedScenarios++;
 					}
 				});
@@ -78,7 +78,13 @@
 						step.result.searchKeyword = ":" + step.result.status + "Step";
 					});
 
-					scenario.status = scenario.result.failedStepCount ? "failed" : (scenario.result.unknownStepCount ? 'unknown' : 'passed');
+					if (scenario.result.failedStepCount || scenario.result.stepCount === scenario.result.skippedStepCount) {
+						scenario.status = "failed";
+					} else if (scenario.result.unknownStepCount) {
+							scenario.status = 'unknown';
+					} else {
+						scenario.status = 'passed';
+					}
 					scenario.result.searchKeyword = ":" + scenario.status + "Scenario";
 				});
 
@@ -94,13 +100,10 @@
 			data.duration = function(feature){
 				var value=0;
 
-				if(isNaN(feature))
-				{
-					value = feature.result.duration;
-				}
-				else
-				{
+				if (!isNaN(feature)) {
 					value = feature;
+				} else if(feature.result.duration) {
+					value = feature.result.duration;
 				}
 
 				if(value<1000000000)