You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
issue (general): We have numerous unneeded imports throughout the files.
I recommend setting up a linter to track down unnecessary imports to reduce the boilerplate and make the format more consistent (for instance in _helpers.py where we have two different ways to import stuff from _text.py). isort is quite easy to setup with black. ruff is another alternative which plays nice with black out of the box, though this discussion would then broaden the discussion to replacing flake8 as well. Both solutions would also require removing comments from "imports blocs", something that I saw quite often in the code base.
From the pyOpenSci comment:
issue (general): We have numerous unneeded imports throughout the files.
I recommend setting up a linter to track down unnecessary imports to reduce the boilerplate and make the format more consistent (for instance in _helpers.py where we have two different ways to import stuff from _text.py). isort is quite easy to setup with black. ruff is another alternative which plays nice with black out of the box, though this discussion would then broaden the discussion to replacing flake8 as well. Both solutions would also require removing comments from "imports blocs", something that I saw quite often in the code base.
pyOpenSci/software-submission#202 (comment)
The text was updated successfully, but these errors were encountered: