Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyOpenSci review] Use linter to help remove unneeded imports across codebase #538

Closed
rich-iannone opened this issue Dec 2, 2024 · 1 comment

Comments

@rich-iannone
Copy link
Member

From the pyOpenSci comment:

issue (general): We have numerous unneeded imports throughout the files.
I recommend setting up a linter to track down unnecessary imports to reduce the boilerplate and make the format more consistent (for instance in _helpers.py where we have two different ways to import stuff from _text.py). isort is quite easy to setup with black. ruff is another alternative which plays nice with black out of the box, though this discussion would then broaden the discussion to replacing flake8 as well. Both solutions would also require removing comments from "imports blocs", something that I saw quite often in the code base.

pyOpenSci/software-submission#202 (comment)

@rich-iannone
Copy link
Member Author

We moved to ruff in #511. So unneeded imports are now gone across all .py files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant