Lots of refactoring and performance updates

Author: ChrisAdderley

GameData/DynamicBatteryStorage/DynamicBatteryStorageSettings.cfg

@@ -238,17 +238,37 @@ DYNAMICBATTERYSTORAGE
     simulated = true
     continuous = true
   }
+ 
   PARTMODULEHANDLER
   {
-    name = ModuleRadioisotopeGenerator
-    handlerModuleName = ModuleRadioisotopeGeneratorPowerHandler
+    // The name of the module
+    name = ModuleRadioisotopeGeneratorPowerHandler
+    // The type of handler - can be Power or Heat
     type = Power
+    // The name of the handler to use
+    handlerModuleName = GenericFieldDataHandler
+    // Is this shown in the UI at all?
     visible = true
+    // Do we use solar distance attenuation?
     solarEfficiencyEffects = false
+    // Is this module a producer by default?
     producer = true
+    // Is this module a consumer by default?
     consumer = false
+    // Does this item start off as active in the UI? Should canonically be true for constant sources/draws
     simulated = true
+    // Does this item count as a continuous power source for the purpose of the UI?
     continuous = true
+    HANDLER_CONFIG
+    {
+      // Field to poll in editor
+      editorFieldName = BasePower
+      // Field to poll in flight
+      flightFieldName = ActualPower
+      // Multiply the output by these if you need to. Convention is that a consumer is negative.
+      editorValueScalar = -1.0
+      flightValueScalar = -1.0
+    }
   }
   PARTMODULEHANDLER
   {
@@ -429,6 +449,9 @@ DYNAMICBATTERYSTORAGE
     simulated = false
     continuous = false
   }
+
+  
+
   PARTMODULEHANDLER
   {
     name = ModuleLight

GameData/DynamicBatteryStorage/Plugins/DynamicBatteryStorage.dll

@@ -6,7 +6,7 @@
     {
         "MAJOR":2,
         "MINOR":3,
-        "PATCH":3,
+        "PATCH":4,
         "BUILD":0
     },
     "KSP_VERSION":

GameData/DynamicBatteryStorage/Versioning/DynamicBatteryStorage.version

@@ -15,8 +15,6 @@ public class EditorVesselDataManager : MonoBehaviour
 
     public static EditorVesselDataManager Instance { get; private set; }
     public VesselElectricalData ElectricalData { get { return electricalData; } }
-    public VesselThermalData HeatData { get { return heatData; } }
-
     public bool Ready { get { return dataReady; } }
 
     #endregion
@@ -26,7 +24,6 @@ public class EditorVesselDataManager : MonoBehaviour
     bool dataReady = false;
 
     VesselElectricalData electricalData;
-    VesselThermalData heatData;
     #endregion
 
     protected void Awake()
@@ -75,31 +72,19 @@ protected void InitializeEditorConstruct(ShipConstruct ship, bool forceReset)
         else
           electricalData.RefreshData(false, ship.Parts);
 
-        if (heatData == null || forceReset)
-          heatData = new VesselThermalData(ship.Parts);
-        else
-          heatData.RefreshData(false, ship.Parts);
-
-
         Utils.Log(String.Format("Dumping electrical database: \n{0}", electricalData.ToString()), Utils.LogType.VesselData);
-        Utils.Log(String.Format("Dumping thermal database: \n{0}", heatData.ToString()), Utils.LogType.VesselData);
-
         dataReady = true;
       }
       else
       {
         Utils.Log(String.Format("Ship is null"), Utils.LogType.VesselData);
         electricalData = new VesselElectricalData(new List<Part>());
-        heatData = new VesselThermalData(new List<Part>());
       }
     }
 
     protected void RemovePart(Part p)
     {
-
       electricalData.RemoveHandlersForPart(p);
-      heatData.RemoveHandlersForPart(p);
-
     }
     #endregion
 
@@ -135,7 +120,7 @@ public void onEditorVesselPartRemoved(GameEvents.HostTargetAction<Part, Part> p)
       Utils.Log("[VAB VesselDataManager][Editor]: Vessel PART REMOVE", Utils.LogType.VesselData);
       if (!HighLogic.LoadedSceneIsEditor) { return; }
 
-      if (electricalData == null || heatData == null)
+      if (electricalData == null)
         InitializeEditorConstruct(EditorLogic.fetch.ship, false);
       else
         RemovePart(p.target);

Source/DynamicBatteryStorage/Data/VABVesselDataManager.cs

@@ -10,8 +10,6 @@ public class VesselDataManager : VesselModule
     #region Accessors
 
     public VesselElectricalData ElectricalData { get { return electricalData; } }
-    public VesselThermalData HeatData { get { return heatData; } }
-
     public bool Ready { get { return dataReady; } }
 
     #endregion
@@ -22,7 +20,6 @@ public class VesselDataManager : VesselModule
     bool vesselLoaded = false;
 
     VesselElectricalData electricalData;
-    VesselThermalData heatData;
     #endregion
 
     protected override void OnStart()
@@ -89,13 +86,8 @@ protected void RefreshVesselData()
         return;
 
       electricalData = new VesselElectricalData(vessel.Parts);
-      heatData = new VesselThermalData(vessel.Parts);
-
       dataReady = true;
-
       Utils.Log(String.Format("Dumping electrical database: \n{0}", electricalData.ToString()), Utils.LogType.VesselData);
-      Utils.Log(String.Format("Dumping thermal database: \n{0}", heatData.ToString()), Utils.LogType.VesselData);
-
     }
   }
 }

Source/DynamicBatteryStorage/Data/VesselDataManager.cs

@@ -79,21 +79,34 @@
     <Compile Include="Data\VesselData.cs" />
     <Compile Include="Data\VesselDataManager.cs" />
     <Compile Include="Data\VesselElectricalData.cs" />
-    <Compile Include="Data\VesselThermalData.cs" />
     <Compile Include="DynamicBatteryStorage.cs" />
     <Compile Include="FormatUtils.cs" />
     <Compile Include="HandlerConfiguration.cs" />
     <Compile Include="HandlerModuleData.cs" />
     <Compile Include="Handlers\GenericFieldDataHandler.cs" />
-    <Compile Include="Handlers\Heat\NFTHeatHandlers.cs" />
-    <Compile Include="Handlers\Heat\StockHeatHandlers.cs" />
     <Compile Include="Handlers\ModuleDataHandler.cs" />
-    <Compile Include="Handlers\Power\KopernicusPowerHandlers.cs" />
-    <Compile Include="Handlers\Power\NFTPowerHandlers.cs" />
-    <Compile Include="Handlers\Power\RealBatteryPowerHandlers.cs" />
-    <Compile Include="Handlers\Power\RemoteTechPowerHandler.cs" />
-    <Compile Include="Handlers\Power\ScanSatPowerHandler.cs" />
-    <Compile Include="Handlers\Power\StockPowerHandlers.cs" />
+    <Compile Include="Handlers\KopernicusPowerHandlers.cs" />
+    <Compile Include="Handlers\PostKerbin\DischargeCapacitorPowerHandler.cs" />
+    <Compile Include="Handlers\PostKerbin\FissionGeneratorPowerHandler.cs" />
+    <Compile Include="Handlers\PostKerbin\ModuleChargeableEnginePowerHandler.cs" />
+    <Compile Include="Handlers\PostKerbin\ModuleCryoTankPowerHandler.cs" />
+    <Compile Include="Handlers\PostKerbin\ModuleCurvedSolarPanelPowerHandler.cs" />
+    <Compile Include="Handlers\PostKerbin\ModuleDeployableCentrifugePowerHandler.cs" />
+    <Compile Include="Handlers\RealBatteryPowerHandlers.cs" />
+    <Compile Include="Handlers\RemoteTechPowerHandler.cs" />
+    <Compile Include="Handlers\ScanSatPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleActiveRadiatorPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleAlternatorPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleCommandPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleDataTransmitterPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleDeployableSolarPanelPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleEnginesPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleGeneratorPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleLightPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleResourceConverterPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleResourceHarvesterPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleScienceConverterPowerHandler.cs" />
+    <Compile Include="Handlers\Stock\ModuleScienceLabPowerHandler.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Settings.cs" />
     <Compile Include="UI\SystemsMonitorUI.cs" />
@@ -108,7 +121,7 @@
     <Compile Include="UI\ToolbarSituation.cs" />
     <Compile Include="UI\Tooltips.cs" />
     <Compile Include="Utils.cs" />
-    <Compile Include="Handlers\Power\WDSPPowerHandlers.cs" />
+    <Compile Include="Handlers\WDSPPowerHandlers.cs" />
   </ItemGroup>
   <ItemGroup />
   <ItemGroup>

Source/DynamicBatteryStorage/Data/VesselThermalData.cs

@@ -1,3 +1,5 @@
+using System;
+
 namespace DynamicBatteryStorage
 {
   /// <summary>
@@ -6,11 +8,14 @@ namespace DynamicBatteryStorage
   /// </summary>
   public class GenericFieldDataHandler : ModuleDataHandler
   {
-    private string editorFieldName;
-    private string flightFieldName;
+    private readonly string editorFieldName;
+    private readonly string flightFieldName;
+
+    private readonly double editorValueScalar = 1.0d;
+    private readonly double flightValueScalar = 1.0d;
 
-    private double editorValueScalar = 1.0d;
-    private double flightValueScalar = 1.0d;
+    private BaseField editorField;
+    private BaseField flightField;
 
     public GenericFieldDataHandler(HandlerModuleData moduleData) : base(moduleData)
     {
@@ -23,16 +28,34 @@ public GenericFieldDataHandler(HandlerModuleData moduleData) : base(moduleData)
     public override bool Initialize(PartModule pm)
     {
       base.Initialize(pm);
+      try
+      {
+        editorField = pm.Fields[editorFieldName];
+      }
+      catch (Exception)
+      {
+        Utils.Warn($"[GenericFieldDataHandler] Issue locating editor field name {editorFieldName} on {pm.moduleName}");
+        return false;
+      }
+      try
+      {
+        flightField = pm.Fields[flightFieldName];
+      }
+      catch (Exception)
+      {
+        Utils.Warn($"[GenericFieldDataHandler] Issue locating flight field name {flightFieldName} on {pm.moduleName}");
+        return false;
+      }
       return true;
     }
     protected override double GetValueEditor()
     {
-      double.TryParse(pm.Fields.GetValue(editorFieldName).ToString(), out double results);
+      double.TryParse(editorField.GetValue(pm).ToString(), out double results);
       return results * editorValueScalar;
     }
     protected override double GetValueFlight()
     {
-      double.TryParse(pm.Fields.GetValue(flightFieldName).ToString(), out double results);
+      double.TryParse(flightField.GetValue(pm).ToString(), out double results);
       return results * flightValueScalar;
     }
   }