Skip to content

Commit 224614b

Browse files
committed
Merge branch '479-fix-docker-image-type' into 'master'
fix(ui): correct docker image generation based on type See merge request postgres-ai/database-lab!665
2 parents ae60dc5 + d5fa834 commit 224614b

File tree

2 files changed

+19
-8
lines changed

2 files changed

+19
-8
lines changed

Diff for: ui/packages/shared/pages/Configuration/index.tsx

+9-2
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,9 @@ export const Configuration = observer(
213213
const handleDockerImageSelect = (
214214
e: React.ChangeEvent<HTMLInputElement>,
215215
) => {
216-
const newDockerImages = formatDockerImageArray(e.target.value)
216+
const selectedDockerImage =
217+
e.target.value === 'rdsAurora' ? 'rds' : e.target.value
218+
const newDockerImages = formatDockerImageArray(selectedDockerImage)
217219
setDockerImages(newDockerImages)
218220
handleSelectPgOptions(
219221
e,
@@ -232,8 +234,13 @@ export const Configuration = observer(
232234
formik.setFieldValue('dockerImageType', e.target.value)
233235

234236
// select latest Postgres version on dockerImage change
235-
if (configData?.dockerImageType !== e.target.value) {
237+
if (
238+
configData?.dockerImageType !== e.target.value &&
239+
selectedDockerImage !== 'custom'
240+
) {
236241
formik.setFieldValue('dockerImage', newDockerImages.slice(-1)[0])
242+
} else if (selectedDockerImage === 'custom') {
243+
formik.setFieldValue('dockerImage', '')
237244
} else {
238245
formik.setFieldValue('dockerImage', configData?.dockerImage)
239246
}

Diff for: ui/packages/shared/pages/Configuration/utils/index.ts

+10-6
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,18 @@ export const getImageType = (imageUrl: string) => {
6565
imageUrl.includes(extendedCustomImage) &&
6666
imageUrl.split(`${extendedCustomImage}-`)[1]?.split(':')[0]
6767

68+
const formattedDockerImageArray = formatDockerImageArray(
69+
postgresCustomImageType || '',
70+
)
71+
72+
const satisfiesDockerTypeAndImage =
73+
dockerImageOptions.some(
74+
(element) => element.type === postgresCustomImageType,
75+
) && formattedDockerImageArray.some((image) => image === imageUrl)
76+
6877
if (imageUrl.includes('postgresai/extended-postgres')) {
6978
return 'Generic Postgres'
70-
} else if (
71-
postgresCustomImageType &&
72-
dockerImageOptions.some((element) =>
73-
element.type.includes(postgresCustomImageType),
74-
)
75-
) {
79+
} else if (postgresCustomImageType && satisfiesDockerTypeAndImage) {
7680
return postgresCustomImageType
7781
} else {
7882
return 'custom'

0 commit comments

Comments
 (0)