Specify default & custom dependencies in packages

Author: qount25

lib/pgpm/deb/builder.rb

@@ -10,7 +10,6 @@ def initialize(spec)
       end
 
       def build
-binding.break
         prepare
         generate_deb_src_files
         pull_image
@@ -23,7 +22,7 @@ def build
 
       # Depends on postgres version and arch
       def image_name
-        "quay.io/qount25/pgpm-debian-pg#{@spec.postgres_major_version}-#{@spec.arch}"
+        "quay.io/qount25/pgpm-debian-pg#{@spec.package.postgres_major_version}-#{@spec.arch}"
       end
 
       def prepare

lib/pgpm/deb/spec.rb

@@ -10,10 +10,11 @@ class Spec
       attr_reader :package, :release, :postgres_version, :postgres_distribution
 
       def initialize(package)
+        @postgres_distribution = Pgpm::Postgres::Distribution.in_scope
         @package = package
+        @package.postgres_major_version = @postgres_distribution.version.split(".")[0]
+        @package.os = "debian"
         @release = 1
-
-        @postgres_distribution = Pgpm::Postgres::Distribution.in_scope
       end
 
       def sources
@@ -27,24 +28,6 @@ def generate(template_name)
         erb.result(binding)
       end
 
-      def deps
-        ["postgresql-#{postgres_major_version}"]
-      end
-
-      def build_deps
-        [
-          "postgresql-#{postgres_major_version}",
-          "build-essential",
-          "postgresql-#{postgres_major_version}",
-          "postgresql-server-dev-#{postgres_major_version}",
-          "postgresql-common"
-        ]
-      end
-
-      def postgres_major_version
-        self.postgres_distribution.version.split(".")[0]
-      end
-
       def source_version
         @package.version.to_s
       end
@@ -64,11 +47,6 @@ def arch
         end
       end
 
-      # Whatever is returned from this method gets added to the "rules" file.
-      def rules_amendments
-        "#"
-      end
-
     end
   end
 end

lib/pgpm/deb/templates/control.erb

@@ -1,13 +1,14 @@
 Source: <%= self.package.name %>-<%= source_version %>
+Description: <%= self.package.description %>
 Section: libs
 Priority: optional
 Maintainer: PGPM Debian maintainer <debian[email protected]>
 Rules-Requires-Root: no
-Build-Depends: debhelper-compat (= 13), <%= build_deps.join(", ") %>
+Build-Depends: debhelper-compat (= 13), <%= self.package.build_dependencies.join(", ") %>
 Standards-Version: 4.6.2
 
 Package: <%= self.package.name %>-<%= source_version %>
-Depends: <%= deps.join(", ") %>
+Depends: <%= self.package.dependencies.join(", ") %>
 Section: libdevel
 Architecture: <%= arch %>
 Description: <%= self.package.description %>

lib/pgpm/deb/templates/copyright.erb

@@ -6,4 +6,4 @@ Upstream-Contact: <preferred name and address to reach the upstream project>
 Files:
  *
 Copyright:
-<%= slef.package.licence %>
+<%= self.package.license %>

lib/pgpm/deb/templates/rules.erb

@@ -18,4 +18,4 @@
 %:
 	dh $@
 
-<%= self.rules_amendments %>
+<%= self.package.build_info[:rules] %>

lib/pgpm/package/building.rb

@@ -7,12 +7,13 @@ def configure_steps
         []
       end
 
-      def build_steps
-        []
-      end
-
-      def install_steps
-        []
+      def build_info
+        case @os
+        when "debian", "ubuntu"
+          { rules: "" }
+        when "rocky", "redhat", "fedora"
+          { build_steps: [], install_steps: [] }
+        end
       end
 
       def source_url_directory_name

lib/pgpm/package/dependencies.rb

@@ -3,14 +3,37 @@
 module Pgpm
   class Package
     module Dependencies
-      def build_dependencies
-        return ["gcc"] if c_files_present?
 
-        []
+      attr_accessor :postgres_major_version
+
+      def build_dependencies
+        case @os
+        when "debian", "ubuntu"
+          [
+            "postgresql-#{postgres_major_version}",
+            "build-essential",
+            "postgresql-#{postgres_major_version}",
+            "postgresql-server-dev-#{postgres_major_version}",
+            "postgresql-common"
+          ]
+        when "rocky", "redhat", "fedora"
+          [
+            "postgresql-#{postgres_major_version}",
+            "build-essential",
+            "postgresql-#{postgres_major_version}",
+            "postgresql-server-devel-#{postgres_major_version}",
+            "postgresql-common"
+          ]
+        end
       end
 
       def dependencies
-        []
+        case @os
+        when "debian", "ubuntu"
+          [ "postgresql-#{postgres_major_version}" ]
+        when "rocky", "redhat", "fedora"
+          [ "postgresql-#{postgres_major_version}" ]
+        end
       end
 
       def requires
@@ -20,6 +43,7 @@ def requires
       def c_files_present?
         Dir.glob("*.c", base: source).any?
       end
+
     end
   end
 end

lib/pgpm/package/packaging.rb

@@ -4,6 +4,8 @@ module Pgpm
   class Package
     module Packaging
 
+      attr_accessor :os
+
       def to_rpm_spec(**opts)
         Pgpm::RPM::Spec.new(self, **opts)
       end

packages/timescale/timescaledb.rb

@@ -11,39 +11,58 @@ def self.package_versions
       super.select { |v| v.to_s =~ /^(\d+\.\d+\.\d+)$/ }
     end
 
-    def summary
-      "TimescaleDB is an open-source database designed to make SQL scalable for time-series data. It is engineered up from PostgreSQL and packaged as a PostgreSQL extension, providing automatic partitioning across time and space (partitioning key), as well as full SQL support."
-    end
-
     def description
-      "An open-source time-series SQL database optimized for fast ingest and complex queries"
+      "An open-source time-series SQL database optimized for fast ingest and " +
+      "complex queries"
     end
 
-    def build_steps
-      [
-        "./bootstrap -DPG_CONFIG=$PG_CONFIG #{bootstrap_flags.map { |f| "-D#{f}" }.join(" ")}",
-        "cmake --build build --parallel"
-      ]
+    def summary
+        "TimescaleDB is an open-source database designed to make SQL "        +
+        "scalable for time-series data. It is engineered up from PostgreSQL " +
+        "and packaged as a PostgreSQL extension, providing automatic "        +
+        "partitioning across time and space (partitioning key), as well as "  +
+        "full SQL support."
     end
 
-    def install_steps
-      [
-        "DESTDIR=$PGPM_BUILDROOT cmake --build build --target install"
-      ]
+    def dependencies
+      super
     end
 
     def build_dependencies
-      super + %w[openssl-devel cmake]
+      deps = case @os
+      when "debian", "ubunut"
+        ["openssl-dev", "cmake"]
+      when "rocky", "redhat", "fedora"
+        ["openssl-devel", "cmake"]
+      end
+      super + deps
     end
 
-    def dependencies
-      super + %w[openssl]
+    def build_info
+      case @os
+      when "debian", "ubuntu"
+        {
+          rules:  "override_dh_auto_configure:\n" +
+                  "  dh_auto_configure -- -DCMAKE_BUILD_TYPE=\"Release\""
+        }
+      when "rocky", "redhat", "fedora"
+        {
+          build_steps: [
+            "./bootstrap -DPG_CONFIG=$PG_CONFIG #{bootstrap_flags.map { |f| "-D#{f}" }.join(" ")}",
+            "cmake --build build --parallel"
+          ],
+          install_steps: [
+            "DESTDIR=$PGPM_BUILDROOT cmake --build build --target install"
+          ]
+        }
+      end
     end
 
     protected
 
     def bootstrap_flags
       []
     end
+
   end
 end