Fix problems reported by "ruff check" (#1)

Author: JelteF

pgcommitfest/commitfest/admin.py

@@ -1,6 +1,6 @@
 from django.contrib import admin
 
-from .models import *
+from .models import CfbotBranch, CfbotTask, Committer, CommitFest, Patch, PatchHistory, PatchOnCommitFest, TargetVersion, Topic, MailThread, MailThreadAttachment
 
 
 class CommitterAdmin(admin.ModelAdmin):

pgcommitfest/commitfest/management/commands/send_notifications.py

@@ -2,7 +2,6 @@
 from django.db import transaction
 from django.conf import settings
 
-from io import StringIO
 
 from pgcommitfest.commitfest.models import PendingNotification
 from pgcommitfest.userprofile.models import UserProfile

pgcommitfest/commitfest/reports.py

@@ -1,6 +1,5 @@
 from django.shortcuts import render, get_object_or_404
 from django.http import Http404
-from django.template import RequestContext
 from django.contrib.auth.decorators import login_required
 from django.db import connection
 

pgcommitfest/commitfest/views.py

@@ -20,7 +20,7 @@
 from pgcommitfest.mailqueue.util import send_mail, send_simple_mail
 from pgcommitfest.userprofile.util import UserWrapper
 
-from .models import CommitFest, Patch, PatchOnCommitFest, PatchHistory, Committer, CfbotBranch, CfbotTask
+from .models import CommitFest, Patch, PatchOnCommitFest, PatchHistory, Committer, CfbotBranch
 from .models import MailThread
 from .forms import PatchForm, NewPatchForm, CommentForm, CommitFestFilterForm
 from .forms import BulkEmailForm
@@ -979,7 +979,7 @@ def thread_notify(request):
         try:
             t = MailThread.objects.get(messageid=m)
             refresh_single_thread(t)
-        except Exception as e:
+        except Exception:
             # Just ignore it, we'll check again later
             pass
 

pgcommitfest/settings.py

@@ -1,5 +1,4 @@
 # Django settings for pgcommitfest project.
-from django.conf import global_settings
 
 DEBUG = False
 TEMPLATE_DEBUG = DEBUG
@@ -173,6 +172,6 @@
 
 # Load local settings overrides
 try:
-    from .local_settings import *
+    from .local_settings import * # noqa: F403
 except ImportError:
     pass

tools/commitfest/check_patches_in_archives.py

@@ -16,13 +16,13 @@
 # Set up for accessing django
 sys.path.append(os.path.join(os.path.abspath(os.path.dirname(sys.argv[0])), '../../'))
 os.environ.setdefault("DJANGO_SETTINGS_MODULE", "pgcommitfest.settings")
-import django
+import django # noqa: E402
 django.setup()
 
-from django.db import connection
-from django.conf import settings
+from django.db import connection  # noqa: E402
+from django.conf import settings  # noqa: E402
 
-from pgcommitfest.commitfest.models import MailThreadAttachment
+from pgcommitfest.commitfest.models import MailThreadAttachment # noqa: E402
 
 if __name__ == "__main__":
     debug = "--debug" in sys.argv

tools/commitfest/update_archive_threads.py

@@ -13,13 +13,13 @@
 # Set up for accessing django
 sys.path.append(os.path.join(os.path.abspath(os.path.dirname(sys.argv[0])), '../../'))
 os.environ.setdefault("DJANGO_SETTINGS_MODULE", "pgcommitfest.settings")
-import django
+import django # noqa: E402
 django.setup()
 
-from django.db import connection
+from django.db import connection # noqa: E402
 
-from pgcommitfest.commitfest.models import MailThread
-from pgcommitfest.commitfest.ajax import refresh_single_thread
+from pgcommitfest.commitfest.models import MailThread # noqa: E402
+from pgcommitfest.commitfest.ajax import refresh_single_thread # noqa: E402
 
 if __name__ == "__main__":
     debug = "--debug" in sys.argv

tools/mail/send_queued_mail.py

@@ -15,12 +15,12 @@
 # Set up to run in django environment
 sys.path.append(os.path.join(os.path.abspath(os.path.dirname(sys.argv[0])), '../../'))
 os.environ.setdefault("DJANGO_SETTINGS_MODULE", "pgcommitfest.settings")
-import django
+import django # noqa: E402
 django.setup()
 
-from django.db import connection, transaction
+from django.db import connection, transaction # noqa: E402
 
-from pgcommitfest.mailqueue.models import QueuedMail
+from pgcommitfest.mailqueue.models import QueuedMail # noqa: E402
 
 if __name__ == "__main__":
     # Grab advisory lock, if available. Lock id is just a random number