Skip to content

Commit df8c7a3

Browse files
committed
Add ID column to commitfest page
The ID of a CF entry is the only stable identifier (people can change the name). That's why tooling such as CFbot uses the ID of the patch for a lot of things (including showing it on the cfbot overview page). Having it visible on the page is quite useful for debugging purposes In eee60a5 the ID was added to the title of the entry, but that made the the title of the page itself less prominent. So this is an attempt to have the information available, but not too prominently visible.
1 parent a9f9a19 commit df8c7a3

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

pgcommitfest/commitfest/templates/commitfest.html

+2
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ <h3>{{p.is_open|yesno:"Active patches,Closed patches"}}</h3>
6161
<thead>
6262
<tr>
6363
<th>{%if p.is_open%}<a href="#" style="color:#333333;" onclick="return sortpatches(0);">Patch</a>{%if sortkey == 0%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-down"></i></div>{%endif%}{%endif%}</th>
64+
<th>{%if p.is_open%}<a href="#" style="color:#333333;" onclick="return sortpatches(4);">ID</a>{%if sortkey == 4%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-down"></i></div>{%endif%}{%else%}ID{%endif%}</th>
6465
<th>Status</th>
6566
<th>Ver</th>
6667
<th>CI status</th>
@@ -85,6 +86,7 @@ <h3>{{p.is_open|yesno:"Active patches,Closed patches"}}</h3>
8586
{%endif%}
8687
<tr>
8788
<td><a href="{{p.id}}/">{{p.name}}</a></td>
89+
<td>{{p.id}}</td>
8890
<td><span class="label label-{{p.status|patchstatuslabel}}">{{p.status|patchstatusstring}}</span></td>
8991
<td>{%if p.targetversion%}<span class="label label-default">{{p.targetversion}}</span>{%endif%}</td>
9092
<td class="cfbot-summary">

pgcommitfest/commitfest/views.py

+2
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,8 @@ def commitfest(request, cfid):
187187
orderby_str = 'lastmail, created'
188188
elif sortkey == 3:
189189
orderby_str = 'num_cfs DESC, modified, created'
190+
elif sortkey == 4:
191+
orderby_str = 'p.id'
190192
else:
191193
orderby_str = 'p.id'
192194
sortkey = 0

0 commit comments

Comments
 (0)