Skip to content

Compilation Issues #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Murthy10 opened this issue Aug 15, 2019 · 5 comments
Closed

Compilation Issues #14

Murthy10 opened this issue Aug 15, 2019 · 5 comments

Comments

@Murthy10
Copy link

I'm running into compilation issues during testing AQO.

Can you propose a release / tag of PostgreSQL and AQO which works together?

For example:

@danolivo
Copy link
Collaborator

Ok. I will do it. I want to bring your attention that branch 'master' corresponds to current master of vanilla PostgreSQL. You used branch 'stable9_6'?
New versions of AQO contains functions that can't be developed in PostgreSQL v.9.6.
I recommend to use PostgreSQL v.11 or v.12 for more effectiveness and stability of results.

@danolivo
Copy link
Collaborator

I studied your issue.
Branches for previous PostgreSQL releases: stable9_6 and stable11 were tested and tagged by corresponding postgres versions.
I checked compilation issues and set tag 12beta3 to the corresponding commit of master branch.
Thanks for your interest.

@Murthy10
Copy link
Author

Thank you for your fast answer and your additional effort.

So I tried it with:

  • PostgreSQL 11 (REL_11_4)
  • AQO stable11

Resulting in an error at the compilation of AQO:

cardinality_estimation.c:2:10: fatal error: optimizer/optimizer.h: No such file or directory
 #include "optimizer/optimizer.h"

@danolivo
Copy link
Collaborator

This line was introduced in commit 339f2ad for PostgreSQL 12beta3 version. In the stable11 I could not see this code. Check your AQO and PostgreSQL code branches.

@Murthy10
Copy link
Author

You are right my fault.
It compiled after: git checkout stable11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants