Skip to content

Commit 473c103

Browse files
author
Roman Nikolaev
committed
Optimize oldest query select (without HAVING)
1 parent 500a813 commit 473c103

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

mamonsu/plugins/pgsql/oldest.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ class Oldest(Plugin):
1919
OldestQuerySql = """
2020
SELECT
2121
CASE WHEN extract(epoch from max(now() - xact_start)) IS NOT null
22+
AND extract(epoch from max(now() - xact_start))>0
2223
THEN extract(epoch from max(now() - xact_start))
2324
ELSE 0
2425
END
2526
FROM pg_catalog.pg_stat_activity
2627
WHERE
2728
pid NOT IN(select pid from pg_stat_replication) AND
2829
pid <> pg_backend_pid() AND
29-
query NOT ilike '%%VACUUM%%'
30-
HAVING extract(epoch from max(now() - xact_start))>0;
30+
query NOT ilike '%%VACUUM%%';
3131
"""
3232

3333
OldestQuerySql_bootstrap = """

mamonsu/tools/bootstrap/sql.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,15 @@
6969
RETURNS DOUBLE PRECISION AS $$
7070
SELECT
7171
CASE WHEN extract(epoch from max(now() - xact_start)) IS NOT null
72+
AND extract(epoch from max(now() - xact_start))>0
7273
THEN extract(epoch from max(now() - xact_start))
7374
ELSE 0
7475
END
7576
FROM pg_catalog.pg_stat_activity
7677
WHERE
7778
pid NOT IN(select pid from pg_stat_replication) AND
7879
pid <> pg_backend_pid() AND
79-
query NOT ilike '%%VACUUM%%'
80-
HAVING extract(epoch from max(now() - xact_start))>0
80+
query NOT ilike '%%VACUUM%%'
8181
$$ LANGUAGE SQL SECURITY DEFINER;
8282
8383
CREATE OR REPLACE FUNCTION public.mamonsu_count_{3}_files()

0 commit comments

Comments
 (0)