PGPRO-3087 Prevent double expand partitioned table by built-in

inheritance and pg_pathman's one

Author: feodor

Diff for: expected/pathman_basic.out

@@ -1804,7 +1804,25 @@ ORDER BY partition;
 
 DROP TABLE test.provided_part_names CASCADE;
 NOTICE:  drop cascades to 2 other objects
+/* test preventing of double expand of inherited tables */
+CREATE TABLE test.mixinh_parent (id INT PRIMARY KEY);
+CREATE TABLE test.mixinh_child1 () INHERITS (test.mixinh_parent);
+SELECT create_range_partitions('test.mixinh_child1', 'id', 1, 10, 1);
+ create_range_partitions 
+-------------------------
+                       1
+(1 row)
+
+INSERT  INTO test.mixinh_child1 VALUES (1);
+SELECT * FROM test.mixinh_child1;
+ id 
+----
+  1
+(1 row)
+
+SELECT * FROM test.mixinh_parent;
+ERROR:  could not expand partitioned table "mixinh_child1"
 DROP SCHEMA test CASCADE;
-NOTICE:  drop cascades to 28 other objects
+NOTICE:  drop cascades to 32 other objects
 DROP EXTENSION pg_pathman CASCADE;
 DROP SCHEMA pathman CASCADE;

Diff for: sql/pathman_basic.sql

@@ -546,6 +546,14 @@ ORDER BY partition;
 
 DROP TABLE test.provided_part_names CASCADE;
 
+/* test preventing of double expand of inherited tables */
+CREATE TABLE test.mixinh_parent (id INT PRIMARY KEY);
+CREATE TABLE test.mixinh_child1 () INHERITS (test.mixinh_parent);
+SELECT create_range_partitions('test.mixinh_child1', 'id', 1, 10, 1);
+INSERT  INTO test.mixinh_child1 VALUES (1);
+SELECT * FROM test.mixinh_child1;
+SELECT * FROM test.mixinh_parent;
+
 DROP SCHEMA test CASCADE;
 DROP EXTENSION pg_pathman CASCADE;
 DROP SCHEMA pathman CASCADE;

Diff for: src/hooks.c

@@ -406,10 +406,16 @@ pathman_rel_pathlist_hook(PlannerInfo *root,
 			 * and added its children to the plan.
 			 */
 			if (appinfo->child_relid == rti &&
-				child_oid == parent_oid &&
 				OidIsValid(appinfo->parent_reloid))
 			{
-				goto cleanup;
+				if (child_oid == parent_oid)
+					goto cleanup;
+				else if (!has_pathman_relation_info(parent_oid))
+					ereport(ERROR,
+							(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+							 errmsg("could not expand partitioned table \"%s\"",
+									get_rel_name(child_oid)),
+							 errhint("Do not use inheritance and pg_pathman partitions together")));
 			}
 		}
 	}