Skip to content

Commit baa88de

Browse files
committed
make compiler happy
1 parent 2ea92ce commit baa88de

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

Diff for: src/catalog.c

+13-12
Original file line numberDiff line numberDiff line change
@@ -688,6 +688,7 @@ pgBackupCreateDir(pgBackup *backup)
688688
parray *
689689
catalog_get_timelines(InstanceConfig *instance)
690690
{
691+
int i,j;
691692
parray *xlog_files_list = parray_new();
692693
parray *timelineinfos;
693694
parray *backups;
@@ -703,7 +704,7 @@ catalog_get_timelines(InstanceConfig *instance)
703704
tlinfo = NULL;
704705

705706
/* walk through files and collect info about timelines */
706-
for (int i = 0; i < parray_num(xlog_files_list); i++)
707+
for (i = 0; i < parray_num(xlog_files_list); i++)
707708
{
708709
pgFile *file = (pgFile *) parray_get(xlog_files_list, i);
709710
TimeLineID tli;
@@ -854,9 +855,9 @@ catalog_get_timelines(InstanceConfig *instance)
854855
tlinfo->parent_tli = tln->tli;
855856

856857
/* find parent timeline to link it with this one */
857-
for (int i = 0; i < parray_num(timelineinfos); i++)
858+
for (j = 0; j < parray_num(timelineinfos); j++)
858859
{
859-
timelineInfo *cur = (timelineInfo *) parray_get(timelineinfos, i);
860+
timelineInfo *cur = (timelineInfo *) parray_get(timelineinfos, j);
860861
if (cur->tli == tlinfo->parent_tli)
861862
{
862863
tlinfo->parent_link = cur;
@@ -875,10 +876,10 @@ catalog_get_timelines(InstanceConfig *instance)
875876
/* save information about backups belonging to each timeline */
876877
backups = catalog_get_backup_list(instance->name, INVALID_BACKUP_ID);
877878

878-
for (int i = 0; i < parray_num(timelineinfos); i++)
879+
for (i = 0; i < parray_num(timelineinfos); i++)
879880
{
880881
timelineInfo *tlinfo = parray_get(timelineinfos, i);
881-
for (int j = 0; j < parray_num(backups); j++)
882+
for (j = 0; j < parray_num(backups); j++)
882883
{
883884
pgBackup *backup = parray_get(backups, j);
884885
if (tlinfo->tli == backup->tli)
@@ -892,7 +893,7 @@ catalog_get_timelines(InstanceConfig *instance)
892893
}
893894

894895
/* determine oldest backup and closest backup for every timeline */
895-
for (int i = 0; i < parray_num(timelineinfos); i++)
896+
for (i = 0; i < parray_num(timelineinfos); i++)
896897
{
897898
timelineInfo *tlinfo = parray_get(timelineinfos, i);
898899

@@ -964,7 +965,7 @@ catalog_get_timelines(InstanceConfig *instance)
964965
*/
965966

966967
/* determine anchor_lsn and keep_segments for every timeline */
967-
for (int i = 0; i < parray_num(timelineinfos); i++)
968+
for (i = 0; i < parray_num(timelineinfos); i++)
968969
{
969970
int count = 0;
970971
timelineInfo *tlinfo = parray_get(timelineinfos, i);
@@ -976,7 +977,7 @@ catalog_get_timelines(InstanceConfig *instance)
976977
*/
977978
if (tlinfo->backups)
978979
{
979-
for (int j = 0; j < parray_num(tlinfo->backups); j++)
980+
for (j = 0; j < parray_num(tlinfo->backups); j++)
980981
{
981982
pgBackup *backup = parray_get(tlinfo->backups, j);
982983

@@ -1127,7 +1128,7 @@ catalog_get_timelines(InstanceConfig *instance)
11271128
}
11281129

11291130
/* Iterate over backups left */
1130-
for (int j = count; j < parray_num(tlinfo->backups); j++)
1131+
for (j = count; j < parray_num(tlinfo->backups); j++)
11311132
{
11321133
XLogSegNo segno = 0;
11331134
xlogInterval *interval = NULL;
@@ -1188,7 +1189,7 @@ catalog_get_timelines(InstanceConfig *instance)
11881189
* We must keep all WAL segments after anchor_lsn (including), and also segments
11891190
* required by ARCHIVE backups for consistency - WAL between [start_lsn, stop_lsn].
11901191
*/
1191-
for (int i = 0; i < parray_num(timelineinfos); i++)
1192+
for (i = 0; i < parray_num(timelineinfos); i++)
11921193
{
11931194
XLogSegNo anchor_segno = 0;
11941195
timelineInfo *tlinfo = parray_get(timelineinfos, i);
@@ -1209,7 +1210,7 @@ catalog_get_timelines(InstanceConfig *instance)
12091210

12101211
GetXLogSegNo(tlinfo->anchor_lsn, anchor_segno, instance->xlog_seg_size);
12111212

1212-
for (int i = 0; i < parray_num(tlinfo->xlog_filelist); i++)
1213+
for (i = 0; i < parray_num(tlinfo->xlog_filelist); i++)
12131214
{
12141215
xlogFile *wal_file = (xlogFile *) parray_get(tlinfo->xlog_filelist, i);
12151216

@@ -1224,7 +1225,7 @@ catalog_get_timelines(InstanceConfig *instance)
12241225
continue;
12251226

12261227
/* Protect segments belonging to one of the keep invervals */
1227-
for (int j = 0; j < parray_num(tlinfo->keep_segments); j++)
1228+
for (j = 0; j < parray_num(tlinfo->keep_segments); j++)
12281229
{
12291230
xlogInterval *keep_segments = (xlogInterval *) parray_get(tlinfo->keep_segments, j);
12301231

Diff for: src/show.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ static int32 json_level = 0;
7777
int
7878
do_show(const char *instance_name, time_t requested_backup_id, bool show_archive)
7979
{
80+
int i;
81+
8082
if (instance_name == NULL &&
8183
requested_backup_id != INVALID_BACKUP_ID)
8284
elog(ERROR, "You must specify --instance to use (-i, --backup-id) option");
@@ -94,7 +96,7 @@ do_show(const char *instance_name, time_t requested_backup_id, bool show_archive
9496
parray *instances = catalog_get_instance_list();
9597

9698
show_instance_start();
97-
for (int i = 0; i < parray_num(instances); i++)
99+
for (i = 0; i < parray_num(instances); i++)
98100
{
99101
InstanceConfig *instance = parray_get(instances, i);
100102
char backup_instance_path[MAXPGPATH];

0 commit comments

Comments
 (0)