[PGPRO-9881] Check return value of SPI_prepare() for NULL

Karina Litskevich · Karina Litskevich · commit 69fd09b0d2a7 · 2024-03-14T17:39:02.000+03:00
Tags: vops
diff --git a/vops.c b/vops.c
@@ -2565,6 +2565,9 @@ Datum vops_populate(PG_FUNCTION_ARGS)
 		n += sprintf(stmt + n, " order by %s", sort);
 	}
     plan = SPI_prepare(stmt, 0, NULL);
+	if (plan == NULL)
+		elog(ERROR, "SPI_prepare(\"%s\") failed:%s",
+			 stmt, SPI_result_code_string(SPI_result));
     portal = SPI_cursor_open(NULL, plan, NULL, NULL, true);
 
 	begin_batch_insert(destination);

Original file line number	Diff line number	Diff line change
`@@ -2565,6 +2565,9 @@ Datum vops_populate(PG_FUNCTION_ARGS)`
`2565`	`2565`	`n += sprintf(stmt + n, " order by %s", sort);`
`2566`	`2566`	`}`
`2567`	`2567`	`plan = SPI_prepare(stmt, 0, NULL);`
	`2568`	`+ if (plan == NULL)`
	`2569`	`+ elog(ERROR, "SPI_prepare(\"%s\") failed:%s",`
	`2570`	`+ stmt, SPI_result_code_string(SPI_result));`
`2568`	`2571`	`portal = SPI_cursor_open(NULL, plan, NULL, NULL, true);`
`2569`	`2572`
`2570`	`2573`	`begin_batch_insert(destination);`