Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline markdown #18

Open
tad-lispy opened this issue Mar 12, 2021 · 0 comments · May be fixed by #19
Open

Inline markdown #18

tad-lispy opened this issue Mar 12, 2021 · 0 comments · May be fixed by #19

Comments

@tad-lispy
Copy link

Hey! Thanks for this plugin. I am playing with PostHTML and it seems very handy.

Would it make sense to support inline markdown content? Like this:

        <markdown>Inline **markdown**</markdown>

Currently (with parcel@nightly) this produces:

TypeError: Cannot read property 'src' of undefined
    at /parcel-2-posthtml-playground/node_modules/posthtml-include-md/index.js:20:28
    at /parcel-2-posthtml-playground/node_modules/posthtml/lib/api.js:91:45
    at traverse (/parcel-2-posthtml-playground/node_modules/posthtml/lib/api.js:105:26)
    at traverse (/parcel-2-posthtml-playground/node_modules/posthtml/lib/api.js:111:5)
    at traverse (/parcel-2-posthtml-playground/node_modules/posthtml/lib/api.js:105:17)
    at traverse (/parcel-2-posthtml-playground/node_modules/posthtml/lib/api.js:111:5)

It seems that there is the posthtml-md plugin which allows inline, but as far as I can see not external content and your plugin that supports external, but not inline content. Both of them implement a <markdown> tag, which makes it tricky to use them together.

Having a single plugin support both cases would be nice.
Scrum added a commit that referenced this issue Mar 15, 2021
@Scrum
fix: inline markdown, close #18
0b6e02a
@Scrum Scrum linked a pull request Mar 15, 2021 that will close this issue
fix: inline markdown, close #18 #19
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: inline markdown, close #18 posthtml/posthtml-include-md
1 participant
@tad-lispy