Skip to content

Commit 50a6f79

Browse files
georgwieseclaude
andcommitted
run_guest_benches: clean apc_candidate_* with find, not a glob
Large guests emit thousands of per-block `apc_candidate_*` snapshots into the shared candidates_dir (e.g. the ~7k-block guest). `rm -f dir/apc_candidate_*` expands the glob into one argv and overflows ARG_MAX on the bench runner ("Argument list too long", exit 126), failing the whole guest-bench job after proving has already succeeded. Use `find -maxdepth 1 -name 'apc_candidate_*' -delete`, which deletes in-process without building a giant argument list. `apc_candidates.json` doesn't match the pattern, so it's still preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 09aeb8b commit 50a6f79

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

openvm-riscv/scripts/run_guest_benches.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,12 @@ run_bench() {
5656
# written into the shared candidates_dir on the first cache-miss run
5757
# and not re-created on cache hits, so this is effectively a one-time
5858
# cleanup per (guest, profile-input).
59-
rm -f "${candidates_dir}"/apc_candidate_*
59+
#
60+
# Use `find -delete` rather than `rm glob`: large guests emit thousands of
61+
# `apc_candidate_*` files (e.g. ~7k blocks), and the expanded glob blows
62+
# past ARG_MAX ("Argument list too long"). `apc_candidates.json` doesn't
63+
# match `apc_candidate_*` (no `_` after `candidate`), so it's preserved.
64+
find "${candidates_dir}" -maxdepth 1 -name 'apc_candidate_*' -delete
6065
}
6166

6267
# TODO: Some benchmarks are currently disabled to keep the nightly run below 6h.

0 commit comments

Comments
 (0)