From 83bcd266f92be5384837e9563c282bca451d7c33 Mon Sep 17 00:00:00 2001
From: Igor Blackman <igor.blackman@gmail.com>
Date: Wed, 20 Nov 2024 14:11:11 -0300
Subject: [PATCH] feat(clusterapi-resource): Parameterize snat (#33)

### PR Description
Depending on the cluster we may have a different SNAT that can be used.
This PR allows override of it.

### Checklist

- [x] Have you reviewed and updated the chart default values if
necessary?
- [ ] Have you reviewed and updated the chart documentation if
necessary?
- [ ] Does your branch follow the naming convention of
`{chartNameWithDashes}-v{versionString}-{optionalPatchVersion}`?
 - [x] Have you bumped the version in the chart's `Chart.yaml`?

### Tagged Releases
Please remember to make a tagged release after merging your PR that:

 - Has a tag name that matches your PR branch name (see above)
 - Has a description that summarizes the changes made

This makes it possible to use previous versions of the charts maintained
here as new releases are published. Please see the release history of
this repository for examples.

Signed-off-by: Igor Valente Blackman <igor.blackman@gmail.com>
---
 .../templates/ConfigMapBigipCtrlAS3.yaml                    | 6 +++---
 charts/clusterapi-resources/values.yaml                     | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/charts/clusterapi-resources/templates/ConfigMapBigipCtrlAS3.yaml b/charts/clusterapi-resources/templates/ConfigMapBigipCtrlAS3.yaml
index 73136eb..917979d 100644
--- a/charts/clusterapi-resources/templates/ConfigMapBigipCtrlAS3.yaml
+++ b/charts/clusterapi-resources/templates/ConfigMapBigipCtrlAS3.yaml
@@ -30,7 +30,7 @@ data:
                 "bigip": "/Common/fastL4"
               },
               "snat": {
-                "bigip": "/Common/SNATPool"
+                "bigip": "{{ .Values.bigipCtrlAS3.snatPool }}"
               },
               "virtualPort": {{ .Values.bigipCtrlAS3.kubeapi.vs.port }},
               "remark": "{{ .Values.cluster.name }} kubeapi vs",
@@ -74,7 +74,7 @@ data:
                 }
               },
               "snat": {
-                "bigip": "/Common/SNATPool"
+                "bigip": "{{ .Values.bigipCtrlAS3.snatPool }}"
               },
               "virtualPort": 443,
               "remark": "{{ .Values.cluster.name }} ingress vs",
@@ -110,7 +110,7 @@ data:
                 }
               },
               "snat": {
-                "bigip": "/Common/SNATPool"
+                "bigip": "{{ .Values.bigipCtrlAS3.snatPool }}"
               },
               "virtualPort": 80,
               "remark": "{{ .Values.cluster.name }} ingress vs",
diff --git a/charts/clusterapi-resources/values.yaml b/charts/clusterapi-resources/values.yaml
index 6570db1..e9d6068 100644
--- a/charts/clusterapi-resources/values.yaml
+++ b/charts/clusterapi-resources/values.yaml
@@ -140,6 +140,7 @@ extraResourcesSecrets: []
 
 # Creates bigip-ctrl AS3 configmap for kubeapi endpoint with manual list of pool members
 bigipCtrlAS3:
+  snatPool: "/Common/SNAT-Pool-List"
   kubeapi:
     enabled: false
     # vs: