Commit 477ba28
authored
[PBNTR-740] Advanced Table - Add Table Props to Rails kit (#4107)
**What does this PR do?** A clear and concise description with your
runway ticket url.
[PBNTR-740](https://runway.powerhrg.com/backlog_items/PBNTR-740) gives
the rails Advanced Table kit access to all of the props of the rails
Table kit under the hood via an optional `table_props` prop.
I tested various table props locally, such as: container: false, sticky:
true, vertical_border: true, striped: true, disable_hover: true.
The doc example matches the [React kit's Table Prop doc
example](https://playbook.powerapp.cloud/kits/advanced_table/react#table-props)
exhibiting container: false (so no outer top and side borders) and
sticky: true (so sticky header happens when scrolling past table).
`table_props` appears in the prop table at the bottom of the kit page.
**Screenshots:** Screenshots to visualize your addition/change
<img width="1131" alt="table props doc ex container sticky"
src="https://github.com/user-attachments/assets/2ad85bdb-3a4d-4aec-9470-de1a19986730"
/>
<img width="888" alt="prop table"
src="https://github.com/user-attachments/assets/9d2e1fcc-c62b-493c-81bd-34114e42146b"
/>
**How to test?** Steps to confirm the desired behavior:
1. Go to review env rails Advanced Table kit [Table Props doc
example](https://pr4107.playbook.beta.hq.powerapp.cloud/kits/advanced_table#table-props).
2. See Table Props doc example - currently nearly matches the React
Table Props doc ex.
#### Checklist:
- [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new
kit`, `deprecated`, or `breaking`. See [Changelog &
Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels)
for details.
- [x] **DEPLOY** I have added the `milano` label to show I'm ready for a
review.
~~- [ ] **TESTS** I have added test coverage to my code.~~1 parent 71d0873 commit 477ba28
File tree
6 files changed
+38
-1
lines changed- playbook/app/pb_kits/playbook/pb_advanced_table
- docs
6 files changed
+38
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
| |||
Lines changed: 33 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
0 commit comments