Skip to content

Commit 10fabc3

Browse files
committed
Rename oldData to previousValues
1 parent e880e28 commit 10fabc3

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

packages/powersync_core/lib/src/crud.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ class CrudEntry {
9191
///
9292
/// This is only tracked for tables for which this has been enabled by setting
9393
/// the [Table.trackPreviousValues].
94-
final Map<String, dynamic>? oldData;
94+
final Map<String, dynamic>? previousValues;
9595

9696
CrudEntry(
9797
this.clientId,
@@ -100,7 +100,7 @@ class CrudEntry {
100100
this.id,
101101
this.transactionId,
102102
this.opData, {
103-
this.oldData,
103+
this.previousValues,
104104
this.metadata,
105105
});
106106

@@ -113,7 +113,7 @@ class CrudEntry {
113113
data['id'] as String,
114114
row['tx_id'] as int,
115115
data['data'] as Map<String, Object?>?,
116-
oldData: data['old'] as Map<String, Object?>?,
116+
previousValues: data['old'] as Map<String, Object?>?,
117117
metadata: data['metadata'] as String?,
118118
);
119119
}
@@ -128,7 +128,7 @@ class CrudEntry {
128128
'tx_id': transactionId,
129129
'data': opData,
130130
'metadata': metadata,
131-
'old': oldData,
131+
'old': previousValues,
132132
};
133133
}
134134

packages/powersync_core/lib/src/schema.dart

+3-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ final class TrackPreviousValuesOptions {
3535
/// A filter of column names for which updates should be tracked.
3636
///
3737
/// When set to a non-null value, columns not included in this list will not
38-
/// appear in [CrudEntry.oldData]. By default, all columns are included.
38+
/// appear in [CrudEntry.previousValues]. By default, all columns are
39+
/// included.
3940
final List<String>? columnFilter;
4041

4142
/// Whether to only include old values when they were changed by an update,
@@ -64,7 +65,7 @@ class Table {
6465
/// through [CrudEntry.metadata].
6566
final bool trackMetadata;
6667

67-
/// Whether to track old values of columns for [CrudEntry.oldData].
68+
/// Whether to track old values of columns for [CrudEntry.previousValues].
6869
///
6970
/// See [TrackPreviousValuesOptions] for details.
7071
final TrackPreviousValuesOptions? trackPreviousValues;

packages/powersync_core/test/crud_test.dart

+4-3
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,8 @@ void main() {
304304
await powersync.execute('UPDATE lists SET name = ?;', ['new name']);
305305

306306
final batch = await powersync.getNextCrudTransaction();
307-
expect(batch!.crud[0].oldData, {'name': 'entry', 'content': 'content'});
307+
expect(batch!.crud[0].previousValues,
308+
{'name': 'entry', 'content': 'content'});
308309
});
309310

310311
test('include old values with column filter', () async {
@@ -325,7 +326,7 @@ void main() {
325326
['new name', 'new content']);
326327

327328
final batch = await powersync.getNextCrudTransaction();
328-
expect(batch!.crud[0].oldData, {'name': 'name'});
329+
expect(batch!.crud[0].previousValues, {'name': 'name'});
329330
});
330331

331332
test('include old values when changed', () async {
@@ -345,7 +346,7 @@ void main() {
345346
await powersync.execute('UPDATE lists SET name = ?', ['new name']);
346347

347348
final batch = await powersync.getNextCrudTransaction();
348-
expect(batch!.crud[0].oldData, {'name': 'name'});
349+
expect(batch!.crud[0].previousValues, {'name': 'name'});
349350
});
350351

351352
test('ignore empty update', () async {

0 commit comments

Comments
 (0)