Skip to content

Commit 4ac574d

Browse files
committed
Remove some generics.
1 parent c43a06e commit 4ac574d

File tree

2 files changed

+21
-104
lines changed

2 files changed

+21
-104
lines changed

packages/stdext-sql-adapter/src/connection.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,7 @@ export interface SqliteConnectionOptions
1919
extends SqlConnectionOptions,
2020
DatabaseOpenOptions {}
2121

22-
export class SqliteConnection
23-
implements
24-
SqlConnection<
25-
SqliteConnectionOptions,
26-
SqliteParameterType,
27-
SqliteQueryOptions
28-
>
29-
{
22+
export class SqliteConnection implements SqlConnection {
3023
public driver: SqliteDriverConnection | undefined;
3124

3225
public readonly connectionUrl: string;
@@ -147,6 +140,7 @@ export class SqliteReservedConnection extends SqliteConnection {
147140
}
148141

149142
async close(): Promise<void> {
143+
this.driver = undefined;
150144
await this.#reserved?.release();
151145
}
152146
}

packages/stdext-sql-adapter/src/core.ts

Lines changed: 19 additions & 96 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import type {
55
SqlClientPool,
66
SqlConnectionOptions,
77
SqlPoolClient,
8-
SqlPoolClientOptions,
98
SqlPreparable,
109
SqlPreparedStatement,
1110
SqlQueriable,
@@ -15,28 +14,26 @@ import type {
1514
SqlTransactionOptions
1615
} from '@stdext/sql';
1716

18-
import type { DatabaseOpenOptions } from './database.js';
1917
import {
20-
SqliteCloseEvent,
21-
SqliteConnectEvent,
22-
SqliteEvents,
23-
SqliteEventTarget
24-
} from './events.js';
18+
ReservedConnection,
19+
SqliteDriverConnectionPool,
20+
SqliteDriverStatement,
21+
SqliteValue
22+
} from '@sqlite-js/driver';
2523
import {
2624
SqliteConnectable,
2725
SqliteConnection,
2826
SqliteReservedConnection,
2927
type SqliteConnectionOptions
3028
} from './connection.js';
29+
import type { DatabaseOpenOptions } from './database.js';
3130
import { SqliteTransactionError } from './errors.js';
32-
import { mergeQueryOptions, transformToAsyncGenerator } from './util.js';
3331
import {
34-
ReservedConnection,
35-
SqliteDriverConnection,
36-
SqliteDriverConnectionPool,
37-
SqliteDriverStatement,
38-
SqliteValue
39-
} from '@sqlite-js/driver';
32+
SqliteCloseEvent,
33+
SqliteConnectEvent,
34+
SqliteEventTarget
35+
} from './events.js';
36+
import { mergeQueryOptions } from './util.js';
4037

4138
export type SqliteParameterType = SqliteValue;
4239
export type BindValue = SqliteValue;
@@ -60,13 +57,7 @@ export interface SqliteClientOptions
6057

6158
export class SqlitePreparedStatement
6259
extends SqliteConnectable
63-
implements
64-
SqlPreparedStatement<
65-
SqliteConnectionOptions,
66-
SqliteParameterType,
67-
SqliteQueryOptions,
68-
SqliteConnection
69-
>
60+
implements SqlPreparedStatement
7061
{
7162
readonly sql: string;
7263
declare readonly options: SqliteConnectionOptions & SqliteQueryOptions;
@@ -221,16 +212,7 @@ export class SqlitePreparedStatement
221212
/**
222213
* Represents a base queriable class for SQLite3.
223214
*/
224-
export class SqliteQueriable
225-
extends SqliteConnectable
226-
implements
227-
SqlQueriable<
228-
SqliteConnectionOptions,
229-
SqliteParameterType,
230-
SqliteQueryOptions,
231-
SqliteConnection
232-
>
233-
{
215+
export class SqliteQueriable extends SqliteConnectable implements SqlQueriable {
234216
declare readonly options: SqliteConnectionOptions & SqliteQueryOptions;
235217

236218
constructor(
@@ -323,26 +305,11 @@ export class SqliteQueriable
323305

324306
export class SqlitePreparable
325307
extends SqliteQueriable
326-
implements
327-
SqlPreparable<
328-
SqliteConnectionOptions,
329-
SqliteParameterType,
330-
SqliteQueryOptions,
331-
SqliteConnection,
332-
SqlitePreparedStatement
333-
> {}
308+
implements SqlPreparable {}
334309

335310
export class SqliteTransaction
336311
extends SqliteQueriable
337-
implements
338-
SqlTransaction<
339-
SqliteConnectionOptions,
340-
SqliteParameterType,
341-
SqliteQueryOptions,
342-
SqliteConnection,
343-
SqlitePreparedStatement,
344-
SqliteTransactionOptions
345-
>
312+
implements SqlTransaction
346313
{
347314
#inTransaction: boolean = true;
348315
get inTransaction(): boolean {
@@ -399,16 +366,7 @@ export class SqliteTransaction
399366
*/
400367
export class SqliteTransactionable
401368
extends SqlitePreparable
402-
implements
403-
SqlTransactionable<
404-
SqliteConnectionOptions,
405-
SqliteParameterType,
406-
SqliteQueryOptions,
407-
SqliteConnection,
408-
SqlitePreparedStatement,
409-
SqliteTransactionOptions,
410-
SqliteTransaction
411-
>
369+
implements SqlTransactionable
412370
{
413371
async beginTransaction(
414372
options?: SqliteTransactionOptions['beginTransactionOptions']
@@ -446,20 +404,7 @@ export class SqliteTransactionable
446404
/**
447405
* Single-connection client. Not safe to use concurrently.
448406
*/
449-
export class SqliteClient
450-
extends SqliteTransactionable
451-
implements
452-
SqlClient<
453-
SqliteEventTarget,
454-
SqliteConnectionOptions,
455-
SqliteParameterType,
456-
SqliteQueryOptions,
457-
SqliteConnection,
458-
SqlitePreparedStatement,
459-
SqliteTransactionOptions,
460-
SqliteTransaction
461-
>
462-
{
407+
export class SqliteClient extends SqliteTransactionable implements SqlClient {
463408
readonly eventTarget: SqliteEventTarget;
464409

465410
constructor(
@@ -554,18 +499,7 @@ class SqlitePoolClient
554499
/**
555500
* Sqlite client
556501
*/
557-
export class SqliteClientPool
558-
implements
559-
SqlClientPool<
560-
SqliteConnectionOptions,
561-
SqliteParameterType,
562-
SqliteQueryOptions,
563-
SqliteConnection,
564-
SqlitePreparedStatement,
565-
SqliteTransactionOptions,
566-
SqliteTransaction
567-
>
568-
{
502+
export class SqliteClientPool implements SqlClientPool {
569503
readonly eventTarget: SqliteEventTarget;
570504

571505
readonly connectionUrl: string;
@@ -584,18 +518,7 @@ export class SqliteClientPool
584518
this.eventTarget = new SqliteEventTarget();
585519
}
586520

587-
async acquire(): Promise<
588-
SqlPoolClient<
589-
SqliteConnectionOptions,
590-
SqliteConnection,
591-
SqliteValue,
592-
SqliteQueryOptions,
593-
SqlitePreparedStatement,
594-
SqliteTransactionOptions,
595-
SqliteTransaction,
596-
SqlPoolClientOptions
597-
>
598-
> {
521+
async acquire(): Promise<SqlPoolClient> {
599522
const reserved = await this.pool.reserveConnection();
600523
return new SqlitePoolClient(this.connectionUrl, reserved, this.options);
601524
}

0 commit comments

Comments
 (0)