Merge pull request #78 from powersync-ja/fix-drift-migrations

Fix drift migrations

Author: rkistner

CHANGELOG.md

@@ -3,6 +3,27 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## 2024-11-06
+
+### Changes
+
+---
+
+Packages with breaking changes:
+
+ - There are no breaking changes in this release.
+
+Packages with other changes:
+
+ - [`drift_sqlite_async` - `v0.2.0`](#drift_sqlite_async---v020)
+
+---
+
+#### `drift_sqlite_async` - `v0.2.0`
+
+ - Automatically run Drift migrations
+
+
 ## 2024-11-06
 
 ### Changes

packages/drift_sqlite_async/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.2.0
+
+ - Automatically run Drift migrations
+
 ## 0.2.0-alpha.4
 
  - Update a dependency to the latest release.

packages/drift_sqlite_async/README.md

@@ -8,6 +8,7 @@ Supported functionality:
 2. Transactions and nested transactions.
 3. Table updates are propagated between sqlite_async and Drift - watching queries works using either API.
 4. Select queries can run concurrently with writes and other select statements.
+5. Drift migrations are supported (optional).
 
 ## Usage
 

packages/drift_sqlite_async/example/main.g.dart

@@ -21,21 +21,18 @@ class AppDatabase extends _$AppDatabase {
 
   @override
   MigrationStrategy get migration {
-    return MigrationStrategy(
-      onCreate: (m) async {
-        // In this example, the schema is managed by Drift
-        await m.createAll();
-      },
-    );
+    return MigrationStrategy(onCreate: (m) async {
+      // In this example, the schema is managed by Drift.
+      // For more options, see:
+      // https://drift.simonbinder.eu/migrations/#usage
+      await m.createAll();
+    });
   }
 }
 
 Future<void> main() async {
   final db = SqliteDatabase(path: 'with_migrations.db');
 
-  await db.execute(
-      'CREATE TABLE IF NOT EXISTS todos(id integer primary key, description text)');
-
   final appdb = AppDatabase(db);
 
   // Watch a query on the Drift database

packages/drift_sqlite_async/example/with_migrations.dart

@@ -15,6 +15,7 @@ class _SqliteAsyncDelegate extends _SqliteAsyncQueryDelegate
     implements DatabaseDelegate {
   final SqliteConnection db;
   bool _closed = false;
+  bool _calledOpen = false;
 
   _SqliteAsyncDelegate(this.db) : super(db, db.writeLock);
 
@@ -30,12 +31,15 @@ class _SqliteAsyncDelegate extends _SqliteAsyncQueryDelegate
       _SqliteAsyncTransactionDelegate(db);
 
   @override
-  bool get isOpen => !db.closed && !_closed;
+  bool get isOpen => !db.closed && !_closed && _calledOpen;
 
   @override
   Future<void> open(QueryExecutorUser user) async {
     // Workaround - this ensures the db is open
     await db.get('SELECT 1');
+    // We need to delay this until open() has been called, otherwise
+    // migrations don't run.
+    _calledOpen = true;
   }
 
   @override