Add back global locks and notes.

Author: rkistner

lib/src/connection_pool.dart

@@ -160,8 +160,11 @@ class SqliteConnectionPool with SqliteQueries implements SqliteConnection {
       return readLock((ctx) => callback(ctx as SqliteWriteContext),
           lockTimeout: lockTimeout, debugContext: debugContext);
     } else {
+      // FIXME:
+      // This should avoid using global locks, but then we need to fix
+      // update notifications to only fire after commit.
       return _writeLock(callback,
-          lockTimeout: lockTimeout, debugContext: debugContext, global: false);
+          lockTimeout: lockTimeout, debugContext: debugContext, global: true);
     }
   }
 

lib/src/sqlite_connection_impl.dart

@@ -105,21 +105,6 @@ class SqliteConnectionImpl with SqliteQueries implements SqliteConnection {
     return _connectionMutex.locked;
   }
 
-  @override
-  Future<T> lock<T>(Future<T> Function(SqliteWriteContext tx) callback,
-      {bool? readOnly, Duration? lockTimeout, String? debugContext}) async {
-    // Private lock to synchronize this with other statements on the same connection,
-    // to ensure that transactions aren't interleaved.
-    return _connectionMutex.lock(() async {
-      final ctx = _TransactionContext(_isolateClient);
-      try {
-        return await callback(ctx);
-      } finally {
-        await ctx.close();
-      }
-    }, timeout: lockTimeout);
-  }
-
   @override
   Future<T> readLock<T>(Future<T> Function(SqliteReadContext tx) callback,
       {Duration? lockTimeout, String? debugContext}) async {

lib/src/sqlite_queries.dart

@@ -164,6 +164,9 @@ mixin SqliteQueries implements SqliteWriteContext, SqliteConnection {
       return readTransaction((ctx) => callback(ctx as SqliteWriteContext),
           lockTimeout: lockTimeout);
     } else {
+      // FIXME:
+      // This should avoid using global locks, but then we need to fix
+      // update notifications to only fire after commit.
       // ignore: deprecated_member_use_from_same_package
       return writeTransaction(callback, lockTimeout: lockTimeout);
     }