Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google OAuth2 authentication changes #37

Open
obaqueiro-primetrust opened this issue Jul 8, 2022 · 0 comments
Open

Google OAuth2 authentication changes #37

obaqueiro-primetrust opened this issue Jul 8, 2022 · 0 comments

Comments

@obaqueiro-primetrust
Copy link

I've got an implementation of Google OAuth2 signin (using the new Google Signin framework) available at master...obaqueiro-primetrust:gremlin-visualizer:google_open_id . Ready to be merged once the Neptune change is made (the oauth2 changes are done on top of the others).

Additionally I have additional changes that will be adding in a separate PR with minor UI improvements (double click node to "expand" both in and out edges) and perform query search when pressing [Enter] in the query input text.

I plan on doing additional improvements to my fork:

  • Implement some kind of "lazy" loading of nodes and edges. Because currently everything is done in 1 request to Gremlin server, we get a lot of Timeouts with queries that get lots of nodes. I can imagine that the hardcoded 100 limit was done as a workaround.
  • Upgrade to newer version of React. There are several npm audit issues and deprecation notices.
  • Implement some kind of UI "feedback" when a query is being performed (spinner in the query buttons, and spinner or something similar on top of the node that is being traversed)
  • Better error communication in the frontend. Currently every error shows the "invalid query" text.
  • Local storage of historic queries.

Long Term / Maybe

  • Maybe the option of saving queries to a server so that they can be shared between people.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant