Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question #6

Open
fakerybakery opened this issue Dec 31, 2023 · 2 comments
Open

Question #6

fakerybakery opened this issue Dec 31, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@fakerybakery
Copy link

Hi,
Thanks for releasing this code. Does this codebase decrease the size of the model (ie file size, required VRAM)?
Thank you!

@dkmisra
Copy link
Collaborator

dkmisra commented Jan 3, 2024

This is one of the feature of LASER but currently the code doesn't do that. This is because we do SVD on a mxn W matrix which gives us U, S, V matrices of size m x m, mxn and nxn respectively, but then we take the top-k dimensions and multiply them back giving back a mxn low-rank approximation of W. To save memory, we should not multiple these matrices back but instead store them as 3 separate matrices of size mxk, kxk, kxn where k is the required low-rank.

The code needs to be modified so that instead of using the modified W parameter we trigger matrix multiplication with 3 separate matrices. This will cut down memory time albeit it will increase the number of sequential steps.

I am adding this as a feature request and we should be able to support this.

@dkmisra dkmisra self-assigned this Jan 3, 2024
@dkmisra dkmisra added the enhancement New feature or request label Jan 3, 2024
@dkmisra
Copy link
Collaborator

dkmisra commented Jan 4, 2024

Related to #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants