chore: update testnet channels again #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
commented
Feb 5, 2025
| @@ -259,7 +259,8 @@ fn process_chain_config(chain_config: ChainConfig) -> AppResult<Registry> { | |||
| .join("assetlist.json"); | |||
|
|
|||
| // Parse the local JSON into the AssetList struct | |||
| let data = fs::read_to_string(assetlist_path)?; | |||
| let data = fs::read_to_string(assetlist_path.clone()).context( | |||
| "failed to read cosmos asset info; did you remember to clone the repo with submodules enabled?")?; | |||
There was a problem hiding this comment.
may this save a future maintainer 10m of hair-pulling 🖖
conorsch
changed the title
This channel was opened this morning by @erwanor, to test the latest code changes just deployed to the Noble testnet. Refs penumbra-zone/penumbra#4899
conorsch
force-pushed
the
testnet-channels-2025-02
branch
from
a5f5749 to
70a6090
Compare
|
TalDerei
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly straightforward change: bump the osmo testnet channel.
Testing and review
I'd like to verify that this setting works, in a local build of prax, but have been unable to do so. Documented some suggestions in #80 (comment).