Merge pull request #689 from pujitm/master

asottile · web-flow · commit ccecdbda02e3 · 2021-12-07T16:03:45.000-05:00
Suggest usable call when executable files lack shebang on Windows
diff --git a/pre_commit_hooks/check_executables_have_shebangs.py b/pre_commit_hooks/check_executables_have_shebangs.py
@@ -64,6 +64,8 @@ def _message(path: str) -> None:
         f'{path}: marked executable but has no (or invalid) shebang!\n'
         f"  If it isn't supposed to be executable, try: "
         f'`chmod -x {shlex.quote(path)}`\n'
+        f'  If on Windows, you may also need to: '
+        f'`git add --chmod=-x {shlex.quote(path)}`\n'
         f'  If it is supposed to be executable, double-check its shebang.',
         file=sys.stderr,
     )

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,8 @@ def _message(path: str) -> None:`
`64`	`64`	`f'{path}: marked executable but has no (or invalid) shebang!\n'`
`65`	`65`	`f" If it isn't supposed to be executable, try: "`
`66`	`66`	f'`chmod -x {shlex.quote(path)}`\n'
	`67`	`+ f' If on Windows, you may also need to: '`
	`68`	+ f'`git add --chmod=-x {shlex.quote(path)}`\n'
`67`	`69`	`f' If it is supposed to be executable, double-check its shebang.',`
`68`	`70`	`file=sys.stderr,`
`69`	`71`	`)`