Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to build it minification safe? #39

Closed
stefek99 opened this issue Jul 5, 2016 · 4 comments
Closed

How to build it minification safe? #39

stefek99 opened this issue Jul 5, 2016 · 4 comments

Comments

@Foxandxss
Copy link
Member

I personally use $inject for that.

@phra
Copy link
Member

phra commented Jul 14, 2016

you can use this plugin for webpack or instead use $inject annotation.

@phra phra closed this as completed Jul 14, 2016
@stefek99
Copy link
Contributor Author

stefek99 commented Oct 4, 2016

YEAH...

Would be nice to make it min-safe by default...

In fact I regret starting my project with you - the main reason why I use starter projects / seeds / defaults is because I don't like configuring stuff. Convention over configuration, less effort wasted doing repetitive stuff, more mental bandwidth for stuff that matters.

#32
#35
#36

And I also had a few emails back and worth with owner of the project who is also not interested in maintaining it... All in all - I advise against using it.

@escapedcat
Copy link
Contributor

Is this also the reason why webpack -p (for v1 it was also --production) isn't used?
Because this would use default Uglify options which might not work with angular?
Sorry if this is off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants