Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release with numpy >=1.21 #21

Open
deepandas11 opened this issue Jul 19, 2022 · 4 comments
Open

Release with numpy >=1.21 #21

deepandas11 opened this issue Jul 19, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@deepandas11
Copy link

Wondering if there's a timeline for a release that incorporates the usage of numpy>=1.21? Main motivations being:

  1. Security vulnerabilities
  2. Installing poweshap in a python environment becomes troublesome, especially when other libraries in the environment set hard requirements on numpy>1.21
@jvdd jvdd self-assigned this Jul 19, 2022
@jvdd jvdd added the enhancement New feature or request label Jul 19, 2022
@jvdd
Copy link
Member

jvdd commented Jul 19, 2022

Hi @deepandas11,

Thx for your suggestion! I completely agree with your motivation.
The main reason why we fixated our dependencies was to support python 3.7 (to support sklearn v0 as well).

However, as major libraries (pandas, numpy, sklearn) are dropping support for Python 3.7, I think it is fine for us to do the same (certainly in the light of security vulnerabilities).

I'll look into it in the near future :)

Cheers,
Jeroen

@jvdd jvdd mentioned this issue Jul 19, 2022
2 tasks
@jvdd
Copy link
Member

jvdd commented Jul 19, 2022

I updated the dependencies in PR #22 and already created a release candidate;
pip install powershap==0.0.8rc1

Let me know if this works for you! 😄

@deepandas11
Copy link
Author

deepandas11 commented Jul 19, 2022

I updated the dependencies in PR #22 and already created a release candidate; pip install powershap==0.0.8rc1

Let me know if this works for you! 😄

Thanks for responding so fast! Appreciate the concern.

However, this doesn't entirely fix my problem. Do let me know if the following is workable?
https://github.com/predict-idlab/powershap/pull/22/files#r924985993
https://github.com/predict-idlab/powershap/pull/22/files#r925017393

@jvdd
Copy link
Member

jvdd commented Jan 12, 2023

Hey @deepandas11,

Just wondering if this is still an issue?
If so, can you elaborate some more on this?

Cheers,
Jeroen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants