Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow for adding a new input type #64

Open
ghost opened this issue Jul 4, 2018 · 4 comments
Open

Workflow for adding a new input type #64

ghost opened this issue Jul 4, 2018 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented Jul 4, 2018

  • [JS] add the js input_type to the api.czrInputMap in a specific file in assets\czr\sek\js\_dev_control\inputs\
  • [PHP] add the input_type case in the switch statement in inc\sektions\_dev_php\input_tmpl\3_0_1_sek_input_tmpl_base_filter.php
  • [PHP] add the input_type callback in a file in inc\sektions\_dev_php\input_tmpl\
  • [Grunt] add the new php and js files to the concat task in __grunt-tasks-config__\concat.js

Notes

@eri-trabiccolo If you need to add a new type of params to an input tmpl when registrating the module ( for example the code_type, you'll need to declare this new param here https://github.com/presscustomizr/czr-base-fmk/blob/master/_dev_php/0_3_czr-base-fmk-tmpl_builder.php#L14.

@eri-trabiccolo
Copy link
Collaborator

About:
[JS] add the js input_type to the api.czrInputMap in a specific file in assets\czr\sek\js_dev_control\inputs\

cannot see that '\inputs' directory do I have to create it and then concat the js file (in which order?)?

@ghost
Copy link
Author

ghost commented Jul 4, 2018

It's fresh, I'm pushing it in a moment :)

@eri-trabiccolo
Copy link
Collaborator

Ah,
ok let me know when I can pull so that I can follow the new workflow.
Thanks.

@ghost
Copy link
Author

ghost commented Jul 4, 2018

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant